fix: move toasts location to left side (#18705)

2026-05-04 00:44:05 -07:00 · 2026-02-10 08:39:28 -05:00
parent e151b4890b
commit 79753ec5ec
8 changed files with 342 additions and 241 deletions
@@ -0,0 +1,165 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import { describe, it, expect, vi, afterEach } from 'vitest';
+import { renderWithProviders } from '../../test-utils/render.js';
+import { ToastDisplay, shouldShowToast } from './ToastDisplay.js';
+import { TransientMessageType } from '../../utils/events.js';
+import { type UIState } from '../contexts/UIStateContext.js';
+import { type TextBuffer } from './shared/text-buffer.js';
+import { type HistoryItem } from '../types.js';
+
+const renderToastDisplay = (uiState: Partial<UIState> = {}) =>
+  renderWithProviders(<ToastDisplay />, {
+    uiState: {
+      buffer: { text: '' } as TextBuffer,
+      history: [] as HistoryItem[],
+      ...uiState,
+    },
+  });
+
+describe('ToastDisplay', () => {
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
+  describe('shouldShowToast', () => {
+    const baseState: Partial<UIState> = {
+      ctrlCPressedOnce: false,
+      transientMessage: null,
+      ctrlDPressedOnce: false,
+      showEscapePrompt: false,
+      buffer: { text: '' } as TextBuffer,
+      history: [] as HistoryItem[],
+      queueErrorMessage: null,
+    };
+
+    it('returns false for default state', () => {
+      expect(shouldShowToast(baseState as UIState)).toBe(false);
+    });
+
+    it('returns true when ctrlCPressedOnce is true', () => {
+      expect(
+        shouldShowToast({ ...baseState, ctrlCPressedOnce: true } as UIState),
+      ).toBe(true);
+    });
+
+    it('returns true when transientMessage is present', () => {
+      expect(
+        shouldShowToast({
+          ...baseState,
+          transientMessage: { text: 'test', type: TransientMessageType.Hint },
+        } as UIState),
+      ).toBe(true);
+    });
+
+    it('returns true when ctrlDPressedOnce is true', () => {
+      expect(
+        shouldShowToast({ ...baseState, ctrlDPressedOnce: true } as UIState),
+      ).toBe(true);
+    });
+
+    it('returns true when showEscapePrompt is true and buffer is NOT empty', () => {
+      expect(
+        shouldShowToast({
+          ...baseState,
+          showEscapePrompt: true,
+          buffer: { text: 'some text' } as TextBuffer,
+        } as UIState),
+      ).toBe(true);
+    });
+
+    it('returns true when showEscapePrompt is true and history is NOT empty', () => {
+      expect(
+        shouldShowToast({
+          ...baseState,
+          showEscapePrompt: true,
+          history: [{ id: '1' } as unknown as HistoryItem],
+        } as UIState),
+      ).toBe(true);
+    });
+
+    it('returns false when showEscapePrompt is true but buffer and history are empty', () => {
+      expect(
+        shouldShowToast({
+          ...baseState,
+          showEscapePrompt: true,
+        } as UIState),
+      ).toBe(false);
+    });
+
+    it('returns true when queueErrorMessage is present', () => {
+      expect(
+        shouldShowToast({
+          ...baseState,
+          queueErrorMessage: 'error',
+        } as UIState),
+      ).toBe(true);
+    });
+  });
+
+  it('renders nothing by default', () => {
+    const { lastFrame } = renderToastDisplay();
+    expect(lastFrame()).toBe('');
+  });
+
+  it('renders Ctrl+C prompt', () => {
+    const { lastFrame } = renderToastDisplay({
+      ctrlCPressedOnce: true,
+    });
+    expect(lastFrame()).toMatchSnapshot();
+  });
+
+  it('renders warning message', () => {
+    const { lastFrame } = renderToastDisplay({
+      transientMessage: {
+        text: 'This is a warning',
+        type: TransientMessageType.Warning,
+      },
+    });
+    expect(lastFrame()).toMatchSnapshot();
+  });
+
+  it('renders hint message', () => {
+    const { lastFrame } = renderToastDisplay({
+      transientMessage: {
+        text: 'This is a hint',
+        type: TransientMessageType.Hint,
+      },
+    });
+    expect(lastFrame()).toMatchSnapshot();
+  });
+
+  it('renders Ctrl+D prompt', () => {
+    const { lastFrame } = renderToastDisplay({
+      ctrlDPressedOnce: true,
+    });
+    expect(lastFrame()).toMatchSnapshot();
+  });
+
+  it('renders Escape prompt when buffer is empty', () => {
+    const { lastFrame } = renderToastDisplay({
+      showEscapePrompt: true,
+      history: [{ id: 1, type: 'user', text: 'test' }] as HistoryItem[],
+    });
+    expect(lastFrame()).toMatchSnapshot();
+  });
+
+  it('renders Escape prompt when buffer is NOT empty', () => {
+    const { lastFrame } = renderToastDisplay({
+      showEscapePrompt: true,
+      buffer: { text: 'some text' } as TextBuffer,
+    });
+    expect(lastFrame()).toMatchSnapshot();
+  });
+
+  it('renders Queue Error Message', () => {
+    const { lastFrame } = renderToastDisplay({
+      queueErrorMessage: 'Queue Error',
+    });
+    expect(lastFrame()).toMatchSnapshot();
+  });
+});