mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-04-27 13:34:15 -07:00
feat(core): instrument file system tools for JIT context discovery (#22082)
This commit is contained in:
@@ -0,0 +1,131 @@
|
||||
/**
|
||||
* @license
|
||||
* Copyright 2026 Google LLC
|
||||
* SPDX-License-Identifier: Apache-2.0
|
||||
*/
|
||||
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
||||
import { discoverJitContext, appendJitContext } from './jit-context.js';
|
||||
import type { Config } from '../config/config.js';
|
||||
import type { ContextManager } from '../services/contextManager.js';
|
||||
|
||||
describe('jit-context', () => {
|
||||
describe('discoverJitContext', () => {
|
||||
let mockConfig: Config;
|
||||
let mockContextManager: ContextManager;
|
||||
|
||||
beforeEach(() => {
|
||||
mockContextManager = {
|
||||
discoverContext: vi.fn().mockResolvedValue(''),
|
||||
} as unknown as ContextManager;
|
||||
|
||||
mockConfig = {
|
||||
isJitContextEnabled: vi.fn().mockReturnValue(false),
|
||||
getContextManager: vi.fn().mockReturnValue(mockContextManager),
|
||||
getWorkspaceContext: vi.fn().mockReturnValue({
|
||||
getDirectories: vi.fn().mockReturnValue(['/app']),
|
||||
}),
|
||||
} as unknown as Config;
|
||||
});
|
||||
|
||||
it('should return empty string when JIT is disabled', async () => {
|
||||
vi.mocked(mockConfig.isJitContextEnabled).mockReturnValue(false);
|
||||
|
||||
const result = await discoverJitContext(mockConfig, '/app/src/file.ts');
|
||||
|
||||
expect(result).toBe('');
|
||||
expect(mockContextManager.discoverContext).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should return empty string when contextManager is undefined', async () => {
|
||||
vi.mocked(mockConfig.isJitContextEnabled).mockReturnValue(true);
|
||||
vi.mocked(mockConfig.getContextManager).mockReturnValue(undefined);
|
||||
|
||||
const result = await discoverJitContext(mockConfig, '/app/src/file.ts');
|
||||
|
||||
expect(result).toBe('');
|
||||
});
|
||||
|
||||
it('should call contextManager.discoverContext with correct args when JIT is enabled', async () => {
|
||||
vi.mocked(mockConfig.isJitContextEnabled).mockReturnValue(true);
|
||||
vi.mocked(mockContextManager.discoverContext).mockResolvedValue(
|
||||
'Subdirectory context content',
|
||||
);
|
||||
|
||||
const result = await discoverJitContext(mockConfig, '/app/src/file.ts');
|
||||
|
||||
expect(mockContextManager.discoverContext).toHaveBeenCalledWith(
|
||||
'/app/src/file.ts',
|
||||
['/app'],
|
||||
);
|
||||
expect(result).toBe('Subdirectory context content');
|
||||
});
|
||||
|
||||
it('should pass all workspace directories as trusted roots', async () => {
|
||||
vi.mocked(mockConfig.isJitContextEnabled).mockReturnValue(true);
|
||||
vi.mocked(mockConfig.getWorkspaceContext).mockReturnValue({
|
||||
getDirectories: vi.fn().mockReturnValue(['/app', '/lib']),
|
||||
} as unknown as ReturnType<Config['getWorkspaceContext']>);
|
||||
vi.mocked(mockContextManager.discoverContext).mockResolvedValue('');
|
||||
|
||||
await discoverJitContext(mockConfig, '/app/src/file.ts');
|
||||
|
||||
expect(mockContextManager.discoverContext).toHaveBeenCalledWith(
|
||||
'/app/src/file.ts',
|
||||
['/app', '/lib'],
|
||||
);
|
||||
});
|
||||
|
||||
it('should return empty string when no new context is found', async () => {
|
||||
vi.mocked(mockConfig.isJitContextEnabled).mockReturnValue(true);
|
||||
vi.mocked(mockContextManager.discoverContext).mockResolvedValue('');
|
||||
|
||||
const result = await discoverJitContext(mockConfig, '/app/src/file.ts');
|
||||
|
||||
expect(result).toBe('');
|
||||
});
|
||||
|
||||
it('should return empty string when discoverContext throws', async () => {
|
||||
vi.mocked(mockConfig.isJitContextEnabled).mockReturnValue(true);
|
||||
vi.mocked(mockContextManager.discoverContext).mockRejectedValue(
|
||||
new Error('Permission denied'),
|
||||
);
|
||||
|
||||
const result = await discoverJitContext(mockConfig, '/app/src/file.ts');
|
||||
|
||||
expect(result).toBe('');
|
||||
});
|
||||
});
|
||||
|
||||
describe('appendJitContext', () => {
|
||||
it('should return original content when jitContext is empty', () => {
|
||||
const content = 'file contents here';
|
||||
const result = appendJitContext(content, '');
|
||||
|
||||
expect(result).toBe(content);
|
||||
});
|
||||
|
||||
it('should append delimited context when jitContext is non-empty', () => {
|
||||
const content = 'file contents here';
|
||||
const jitContext = 'Use the useAuth hook.';
|
||||
|
||||
const result = appendJitContext(content, jitContext);
|
||||
|
||||
expect(result).toContain(content);
|
||||
expect(result).toContain('--- Newly Discovered Project Context ---');
|
||||
expect(result).toContain(jitContext);
|
||||
expect(result).toContain('--- End Project Context ---');
|
||||
});
|
||||
|
||||
it('should place context after the original content', () => {
|
||||
const content = 'original output';
|
||||
const jitContext = 'context rules';
|
||||
|
||||
const result = appendJitContext(content, jitContext);
|
||||
|
||||
const contentIndex = result.indexOf(content);
|
||||
const contextIndex = result.indexOf(jitContext);
|
||||
expect(contentIndex).toBeLessThan(contextIndex);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user