MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-07-15 12:30:32 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(hooks): resolve Windows flakiness and improve reliability

Browse Source
This commit is contained in:
Taylor Mullen
2026-02-10 13:34:57 -08:00
parent b077cfe061
commit 80a0f04cfd
7 changed files with 129 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-tests/hooks-system.test.ts
+9 -9
View File
@@ -87,7 +87,7 @@ describe('Hooks System Integration', () => {
expect(hookTelemetryFound).toBeTruthy();
});
it.only('should block tool execution and use stderr as reason when hook exits with code 2', async () => {
it('should block tool execution and use stderr as reason when hook exits with code 2', async () => {
rig.setup(
'should block tool execution and use stderr as reason when hook exits with code 2',
{
@@ -110,7 +110,6 @@ process.exit(0);
);
const normalizedCmd = normalizePath(`node "${scriptPath}"`);
console.log(`[Test] normalizedCmd: ${normalizedCmd}`);
rig.setup(
'should block tool execution and use stderr as reason when hook exits with code 2',
@@ -156,14 +155,17 @@ process.exit(0);
// Result should mention the blocking reason from stderr
expect(result).toContain('File writing blocked by security policy');
// Verify hook telemetry shows exit code 2 and stderr
// Verify hook telemetry shows the deny decision
const hookLogs = rig.readHookLogs();
const blockHook = hookLogs.find((log) => log.hookCall.exit_code === 2);
const blockHook = hookLogs.find(
(log) =>
log.hookCall.hook_name.includes('stderr_block_hook.cjs') &&
log.hookCall.hook_output.includes('"decision":"deny"'),
);
expect(blockHook).toBeDefined();
expect(blockHook?.hookCall.stderr).toContain(
expect(blockHook?.hookCall.hook_output).toContain(
'File writing blocked by security policy',
);
expect(blockHook?.hookCall.success).toBe(false);
});
it('should allow tool execution when hook returns allow decision', async () => {
@@ -1894,10 +1896,9 @@ console.log(JSON.stringify({decision: "block", systemMessage: "Disabled hook sho
expect(disabledHookLog).toBeUndefined();
});
it.only('should respect disabled hooks across multiple operations', async () => {
it('should respect disabled hooks across multiple operations', async () => {
// 1. First setup to get the test directory and prepare the hook scripts
rig.setup('should respect disabled hooks across multiple operations');
console.log(`[Test] testDir: ${rig.testDir}`);
const activeHookScript = `const fs = require('fs');
console.log(JSON.stringify({decision: "allow", systemMessage: "Active hook executed"}));`;
@@ -1911,7 +1912,6 @@ console.log(JSON.stringify({decision: "block", systemMessage: "Disabled hook sho
writeFileSync(disabledPath, disabledHookScript);
const normalizedDisabledCmd = normalizePath(`node "${disabledPath}"`);
console.log(`[Test] normalizedDisabledCmd: ${normalizedDisabledCmd}`);
rig.setup('should respect disabled hooks across multiple operations', {
settings: {