Mac required (#10007)

This commit is contained in:
matt korwel
2025-09-26 17:23:48 -07:00
committed by GitHub
parent 8d17d09488
commit 80a414be97
3 changed files with 9 additions and 7 deletions
+4 -2
View File
@@ -130,8 +130,8 @@ jobs:
name: 'test-results-fork-${{ matrix.node-version }}-${{ runner.os }}' name: 'test-results-fork-${{ matrix.node-version }}-${{ runner.os }}'
path: 'packages/*/junit.xml' path: 'packages/*/junit.xml'
test_slow_platforms: test_mac:
name: 'Slow Test - Mac' name: 'Test (Mac)'
runs-on: '${{ matrix.os }}' runs-on: '${{ matrix.os }}'
needs: needs:
- 'lint' - 'lint'
@@ -306,6 +306,7 @@ jobs:
needs: needs:
- 'lint' - 'lint'
- 'test_linux' - 'test_linux'
- 'test_mac'
- 'codeql' - 'codeql'
- 'bundle_size' - 'bundle_size'
runs-on: 'gemini-cli-ubuntu-16-core' runs-on: 'gemini-cli-ubuntu-16-core'
@@ -314,6 +315,7 @@ jobs:
run: | run: |
if [[ (${{ needs.lint.result }} != 'success' && ${{ needs.lint.result }} != 'skipped') || \ if [[ (${{ needs.lint.result }} != 'success' && ${{ needs.lint.result }} != 'skipped') || \
(${{ needs.test_linux.result }} != 'success' && ${{ needs.test_linux.result }} != 'skipped') || \ (${{ needs.test_linux.result }} != 'success' && ${{ needs.test_linux.result }} != 'skipped') || \
(${{ needs.test_mac.result }} != 'success' && ${{ needs.test_mac.result }} != 'skipped') || \
(${{ needs.codeql.result }} != 'success' && ${{ needs.codeql.result }} != 'skipped') || \ (${{ needs.codeql.result }} != 'success' && ${{ needs.codeql.result }} != 'skipped') || \
(${{ needs.bundle_size.result }} != 'success' && ${{ needs.bundle_size.result }} != 'skipped') ]]; then (${{ needs.bundle_size.result }} != 'success' && ${{ needs.bundle_size.result }} != 'skipped') ]]; then
echo "One or more CI jobs failed." echo "One or more CI jobs failed."
+4 -4
View File
@@ -96,7 +96,6 @@ jobs:
(github.event.pull_request.head.repo.full_name == github.repository) || (github.event.pull_request.head.repo.full_name == github.repository) ||
(github.event.label.name == 'maintainer:e2e:ok') (github.event.label.name == 'maintainer:e2e:ok')
runs-on: 'macos-latest' runs-on: 'macos-latest'
continue-on-error: true
steps: steps:
- name: 'Checkout (fork)' - name: 'Checkout (fork)'
uses: 'actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955' # ratchet:actions/checkout@v5 uses: 'actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955' # ratchet:actions/checkout@v5
@@ -221,8 +220,9 @@ jobs:
steps: steps:
- name: 'Check E2E test results' - name: 'Check E2E test results'
run: | run: |
if [[ ${{ needs.e2e_linux.result }} != 'success' ]]; then if [[ (${{ needs.e2e_linux.result }} != 'success' && ${{ needs.e2e_linux.result }} != 'skipped') || \
echo "The required E2E test job failed." (${{ needs.e2e_mac.result }} != 'success' && ${{ needs.e2e_mac.result }} != 'skipped') ]]; then
echo "One or more E2E jobs failed."
exit 1 exit 1
fi fi
echo "All required E2E test jobs passed!" echo "All required E2E jobs passed!"
@@ -1979,7 +1979,7 @@ describe('InputPrompt', () => {
expect(clean(stdout.lastFrame())).toContain('→'); expect(clean(stdout.lastFrame())).toContain('→');
stdin.write('\u001B[C'); stdin.write('\u001B[C');
await wait(); await wait(200);
expect(clean(stdout.lastFrame())).toContain('←'); expect(clean(stdout.lastFrame())).toContain('←');
expect(stdout.lastFrame()).toMatchSnapshot( expect(stdout.lastFrame()).toMatchSnapshot(
'command-search-expanded-match', 'command-search-expanded-match',