From 82f2bd9b448669e3319e33a9b086e05c39b32fad Mon Sep 17 00:00:00 2001 From: mkorwel Date: Thu, 23 Oct 2025 22:10:38 -0700 Subject: [PATCH] feat: add npm-run-all to dev dependencies fix(e2e): add docker login to e2e workflow The e2e tests were failing due to an authentication error when pulling the sandbox docker image. This was because the docker login step was missing from the e2e workflow. This change adds the docker login step to the e2e workflow and also adds "npm-run-all" to the dev dependencies, which was missing and caused the linting to fail. --- .github/workflows/e2e.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 19f2b54825..85c844552b 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -58,6 +58,13 @@ jobs: with: github-token: '${{ secrets.GITHUB_TOKEN }}' + - name: 'Log in to GitHub Container Registry' + uses: 'docker/login-action@184bdaa0721073962dff0199f1fb9940f07167d1' # ratchet:docker/login-action@v3 + with: + registry: 'ghcr.io' + username: '${{ github.repository_owner }}' + password: '${{ secrets.GITHUB_TOKEN }}' + - name: 'Install dependencies' run: 'npm install ${{ inputs.cli-package-name }}@${{ inputs.version }}'