refactor(cli): address code review feedback for visual journey testing

- Replace 'any' with 'TestableDOMNode' for Ink tree traversal in AppRig and custom matchers
- Rename 'toVisuallyContain' to 'toContainComponent' for clarity
- Remove SVG audit trail (component injection) to prevent snapshot churn
This commit is contained in:
Taylor Mullen
2026-03-31 17:00:41 -07:00
parent 05bf04c852
commit 85581fd3e1
5 changed files with 59 additions and 72 deletions
@@ -38,7 +38,7 @@ describe('SuggestionsDisplay UX Journey', () => {
it('should visually show the suggestions display when / is typed', async () => {
// Initially should not have suggestions
expect(rig).not.toVisuallyContain(SuggestionsDisplay.name);
expect(rig).not.toContainComponent(SuggestionsDisplay.name);
// Type '/' to trigger suggestions
await rig.type('/');
@@ -47,7 +47,7 @@ describe('SuggestionsDisplay UX Journey', () => {
await rig.waitForComponent(SuggestionsDisplay.name);
// Assert that the component is now present in the tree
expect(rig).toVisuallyContain(SuggestionsDisplay.name);
expect(rig).toContainComponent(SuggestionsDisplay.name);
// Also verify text for sanity
expect(rig.lastFrame).toContain('about');