fix(cli): enable and fix types for MCP command tests (#11385)

This commit is contained in:
Sandy Tao
2025-10-17 11:23:26 -07:00
committed by GitHub
parent 2b61ac532d
commit 8da47db1a4
4 changed files with 55 additions and 25 deletions
+8 -7
View File
@@ -4,7 +4,8 @@
* SPDX-License-Identifier: Apache-2.0
*/
import yargs from 'yargs';
import { describe, it, expect, vi, type Mock } from 'vitest';
import yargs, { type Argv } from 'yargs';
import { addCommand } from './add.js';
import { loadSettings, SettingScope } from '../../config/settings.js';
@@ -31,12 +32,12 @@ vi.mock('../../config/settings.js', async () => {
};
});
const mockedLoadSettings = loadSettings as vi.Mock;
const mockedLoadSettings = loadSettings as Mock;
describe('mcp add command', () => {
let parser: yargs.Argv;
let mockSetValue: vi.Mock;
let mockConsoleError: vi.Mock;
let parser: Argv;
let mockSetValue: Mock;
let mockConsoleError: Mock;
beforeEach(() => {
vi.resetAllMocks();
@@ -207,7 +208,7 @@ describe('mcp add command', () => {
.spyOn(process, 'exit')
.mockImplementation((() => {
throw new Error('process.exit called');
}) as (code?: number) => never);
}) as (code?: number | string | null) => never);
await expect(
parser.parseAsync(`add ${serverName} ${command}`),
@@ -225,7 +226,7 @@ describe('mcp add command', () => {
.spyOn(process, 'exit')
.mockImplementation((() => {
throw new Error('process.exit called');
}) as (code?: number) => never);
}) as (code?: number | string | null) => never);
await expect(
parser.parseAsync(`add --scope project ${serverName} ${command}`),
+16 -6
View File
@@ -4,8 +4,16 @@
* SPDX-License-Identifier: Apache-2.0
*/
import { vi, describe, it, expect, beforeEach, afterEach } from 'vitest';
import yargs from 'yargs';
import {
vi,
describe,
it,
expect,
beforeEach,
afterEach,
type Mock,
} from 'vitest';
import yargs, { type Argv } from 'yargs';
import { SettingScope, type LoadedSettings } from '../../config/settings.js';
import { removeCommand } from './remove.js';
import * as fs from 'node:fs';
@@ -20,8 +28,8 @@ vi.mock('fs/promises', () => ({
describe('mcp remove command', () => {
describe('unit tests with mocks', () => {
let parser: yargs.Argv;
let mockSetValue: vi.Mock;
let parser: Argv;
let mockSetValue: Mock;
let mockSettings: Record<string, unknown>;
beforeEach(async () => {
@@ -42,7 +50,9 @@ describe('mcp remove command', () => {
).mockReturnValue({
forScope: () => ({ settings: mockSettings }),
setValue: mockSetValue,
} as Partial<LoadedSettings> as LoadedSettings);
workspace: { path: '/path/to/project' },
user: { path: '/home/user' },
} as unknown as LoadedSettings);
const yargsInstance = yargs([]).command(removeCommand);
parser = yargsInstance;
@@ -73,7 +83,7 @@ describe('mcp remove command', () => {
let tempDir: string;
let settingsDir: string;
let settingsPath: string;
let parser: yargs.Argv;
let parser: Argv;
let cwdSpy: ReturnType<typeof vi.spyOn>;
beforeEach(() => {