feat(core): overhaul system prompt for rigor, integrity, and intent alignment (#17263)

packages/core/src/services/chatCompressionService.test.ts

@@ -176,6 +176,7 @@ describe('ChatCompressionService', () => {
         generateContent: mockGenerateContent,
       }),
       isInteractive: vi.fn().mockReturnValue(false),
+      getActiveModel: vi.fn().mockReturnValue(mockModel),
       getContentGenerator: vi.fn().mockReturnValue({
         countTokens: vi.fn().mockResolvedValue({ totalTokens: 100 }),
       }),

packages/core/src/services/chatCompressionService.ts

@@ -335,7 +335,7 @@ export class ChatCompressionService {
           ],
         },
       ],
-      systemInstruction: { text: getCompressionPrompt() },
+      systemInstruction: { text: getCompressionPrompt(config) },
       promptId,
       // TODO(joshualitt): wire up a sensible abort signal,
       abortSignal: abortSignal ?? new AbortController().signal,
@@ -363,7 +363,7 @@ export class ChatCompressionService {
             ],
           },
         ],
-        systemInstruction: { text: getCompressionPrompt() },
+        systemInstruction: { text: getCompressionPrompt(config) },
         promptId: `${promptId}-verify`,
         abortSignal: abortSignal ?? new AbortController().signal,
       });