mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-05-13 05:12:55 -07:00
feat(admin): set admin.skills.enabled based on advancedFeaturesEnabled setting (#17095)
This commit is contained in:
@@ -2200,6 +2200,23 @@ describe('Settings Loading and Merging', () => {
|
|||||||
expect(loadedSettings.merged.admin?.mcp?.enabled).toBe(true);
|
expect(loadedSettings.merged.admin?.mcp?.enabled).toBe(true);
|
||||||
expect(loadedSettings.merged.admin?.extensions?.enabled).toBe(false);
|
expect(loadedSettings.merged.admin?.extensions?.enabled).toBe(false);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('should set skills based on advancedFeaturesEnabled', () => {
|
||||||
|
const loadedSettings = loadSettings();
|
||||||
|
loadedSettings.setRemoteAdminSettings({
|
||||||
|
cliFeatureSetting: {
|
||||||
|
advancedFeaturesEnabled: true,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
expect(loadedSettings.merged.admin.skills?.enabled).toBe(true);
|
||||||
|
|
||||||
|
loadedSettings.setRemoteAdminSettings({
|
||||||
|
cliFeatureSetting: {
|
||||||
|
advancedFeaturesEnabled: false,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
expect(loadedSettings.merged.admin.skills?.enabled).toBe(false);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('getDefaultsFromSchema', () => {
|
describe('getDefaultsFromSchema', () => {
|
||||||
|
|||||||
@@ -363,6 +363,10 @@ export class LoadedSettings {
|
|||||||
admin.extensions = { enabled: extensionsSetting.extensionsEnabled };
|
admin.extensions = { enabled: extensionsSetting.extensionsEnabled };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (cliFeatureSetting?.advancedFeaturesEnabled !== undefined) {
|
||||||
|
admin.skills = { enabled: cliFeatureSetting.advancedFeaturesEnabled };
|
||||||
|
}
|
||||||
|
|
||||||
this._remoteAdminSettings = { admin };
|
this._remoteAdminSettings = { admin };
|
||||||
this._merged = this.computeMergedSettings();
|
this._merged = this.computeMergedSettings();
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -302,6 +302,7 @@ const ExtensionsSettingSchema = z.object({
|
|||||||
|
|
||||||
const CliFeatureSettingSchema = z.object({
|
const CliFeatureSettingSchema = z.object({
|
||||||
extensionsSetting: ExtensionsSettingSchema.optional(),
|
extensionsSetting: ExtensionsSettingSchema.optional(),
|
||||||
|
advancedFeaturesEnabled: z.boolean().optional(),
|
||||||
});
|
});
|
||||||
|
|
||||||
const McpSettingSchema = z.object({
|
const McpSettingSchema = z.object({
|
||||||
|
|||||||
Reference in New Issue
Block a user