From 94575adb427a300394f7041503945a46cbc480fe Mon Sep 17 00:00:00 2001 From: Michael Bleigh Date: Sun, 12 Apr 2026 19:16:18 -0700 Subject: [PATCH] chore: address PR feedback on type safety and path mappings --- packages/a2a-server/src/agent/task.test.ts | 18 +++++++++--------- packages/core/tsconfig.json | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/a2a-server/src/agent/task.test.ts b/packages/a2a-server/src/agent/task.test.ts index 8a7cb416bb..4853ccbdb4 100644 --- a/packages/a2a-server/src/agent/task.test.ts +++ b/packages/a2a-server/src/agent/task.test.ts @@ -231,11 +231,11 @@ describe('Task', () => { mockEventBus, ); - const event = { + const event: ServerGeminiStreamEvent = { type: GeminiEventType.Content, value: 'test', traceId: 'test-trace-id', - } as const; + }; await task.acceptAgentMessage(event); @@ -268,10 +268,10 @@ describe('Task', () => { ); const citationText = 'Source: example.com'; - const citationEvent = { + const citationEvent: ServerGeminiStreamEvent = { type: GeminiEventType.Citation, value: citationText, - } as const; + }; await task.acceptAgentMessage(citationEvent); @@ -311,10 +311,10 @@ describe('Task', () => { mockEventBus, ); - const modelInfoEvent = { + const modelInfoEvent: ServerGeminiStreamEvent = { type: GeminiEventType.ModelInfo, value: 'new-model-name', - } as const; + }; await task.acceptAgentMessage(modelInfoEvent); @@ -343,7 +343,7 @@ describe('Task', () => { it.each([ { eventType: GeminiEventType.Retry, eventName: 'Retry' }, { eventType: GeminiEventType.InvalidStream, eventName: 'InvalidStream' }, - ])( + ] as const)( 'should handle $eventName event without triggering error handling', async ({ eventType }) => { const mockConfig = createMockConfig(); @@ -367,9 +367,9 @@ describe('Task', () => { const cancelPendingToolsSpy = vi.spyOn(task, 'cancelPendingTools'); const setTaskStateSpy = vi.spyOn(task, 'setTaskStateAndPublishUpdate'); - const event = { + const event: ServerGeminiStreamEvent = { type: eventType, - } as unknown as ServerGeminiStreamEvent; + }; await task.acceptAgentMessage(event); diff --git a/packages/core/tsconfig.json b/packages/core/tsconfig.json index 0dc19b82ad..08435d8904 100644 --- a/packages/core/tsconfig.json +++ b/packages/core/tsconfig.json @@ -6,7 +6,7 @@ "composite": true, "types": ["node", "vitest/globals"], "paths": { - "*": ["./*"], + "src/*": ["./src/*"], "@google/gemini-cli-core": ["./index.ts"] } },