Disallow and suppress unsafe assignment (#19736)

packages/core/src/services/sessionSummaryUtils.ts

@@ -26,6 +26,7 @@ async function generateAndSaveSummary(
 ): Promise<void> {
   // Read session file
   const content = await fs.readFile(sessionPath, 'utf-8');
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
   const conversation: ConversationRecord = JSON.parse(content);
 
   // Skip if summary already exists
@@ -69,6 +70,7 @@ async function generateAndSaveSummary(
 
   // Re-read the file before writing to handle race conditions
   const freshContent = await fs.readFile(sessionPath, 'utf-8');
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
   const freshConversation: ConversationRecord = JSON.parse(freshContent);
 
   // Check if summary was added by another process
@@ -127,6 +129,7 @@ export async function getPreviousSession(
 
     try {
       const content = await fs.readFile(filePath, 'utf-8');
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       const conversation: ConversationRecord = JSON.parse(content);
 
       if (conversation.summary) {

packages/core/src/services/shellExecutionService.ts

@@ -568,6 +568,7 @@ export class ShellExecutionService {
       const guardedCommand = ensurePromptvarsDisabled(commandToExecute, shell);
       const args = [...argsPrefix, guardedCommand];
 
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       const ptyProcess = ptyInfo.module.spawn(executable, args, {
         cwd,
         name: 'xterm-256color',
@@ -598,6 +599,7 @@ export class ShellExecutionService {
         headlessTerminal.scrollToTop();
 
         this.activePtys.set(ptyProcess.pid, {
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
           ptyProcess,
           headlessTerminal,
           maxSerializedLines: shellExecutionConfig.maxSerializedLines,
@@ -831,6 +833,7 @@ export class ShellExecutionService {
                 signal: signal ?? null,
                 error,
                 aborted: abortSignal.aborted,
+                // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
                 pid: ptyProcess.pid,
                 executionMethod: ptyInfo?.name ?? 'node-pty',
               });
@@ -862,9 +865,11 @@ export class ShellExecutionService {
         const abortHandler = async () => {
           if (ptyProcess.pid && !exited) {
             await killProcessGroup({
+              // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
               pid: ptyProcess.pid,
               escalate: true,
               isExited: () => exited,
+              // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
               pty: ptyProcess,
             });
           }
@@ -873,6 +878,7 @@ export class ShellExecutionService {
         abortSignal.addEventListener('abort', abortHandler, { once: true });
       });
 
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       return { pid: ptyProcess.pid, result };
     } catch (e) {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion