MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-12 12:54:07 -07:00
Code Issues Packages Projects Releases Wiki Activity

feat(policy): allow 'modes' in user and admin policies (#15977)

Browse Source
This commit is contained in:
N. Taylor Mullen
2026-01-06 09:56:50 -08:00
committed by GitHub
parent 4c67eef0f2
commit 9a3ff6510f
2 changed files with 5 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/policy/toml-loader.ts
+2 -33
View File
@@ -293,7 +293,6 @@ export async function loadPoliciesFromToml(
// Validate shell command convenience syntax
const tomlRules = validationResult.data.rule ?? [];
const tomlCheckers = validationResult.data.safety_checker ?? [];
for (let i = 0; i < tomlRules.length; i++) {
const rule = tomlRules[i];
@@ -310,36 +309,6 @@ export async function loadPoliciesFromToml(
});
// Continue to next rule, don't skip the entire file
}
if (tier > 1 && rule.modes && rule.modes.length > 0) {
errors.push({
filePath,
fileName: file,
tier: tierName,
ruleIndex: i,
errorType: 'rule_validation',
message: 'Restricted property "modes"',
details: `Rule #${i + 1}: The "modes" property is currently reserved for Tier 1 (system) policies and cannot be used in ${tierName} policies.`,
suggestion: 'Remove the "modes" property from this rule.',
});
}
}
for (let i = 0; i < tomlCheckers.length; i++) {
const checker = tomlCheckers[i];
if (tier > 1 && checker.modes && checker.modes.length > 0) {
errors.push({
filePath,
fileName: file,
tier: tierName,
ruleIndex: i,
errorType: 'rule_validation',
message: 'Restricted property "modes" in safety checker',
details: `Safety Checker #${i + 1}: The "modes" property is currently reserved for Tier 1 (system) policies and cannot be used in ${tierName} policies.`,
suggestion:
'Remove the "modes" property from this safety checker.',
});
}
}
// Transform rules
@@ -375,7 +344,7 @@ export async function loadPoliciesFromToml(
toolName: effectiveToolName,
decision: rule.decision,
priority: transformPriority(rule.priority, tier),
modes: tier === 1 ? rule.modes : undefined,
modes: rule.modes,
allowRedirection: rule.allow_redirection,
};
@@ -440,7 +409,7 @@ export async function loadPoliciesFromToml(
toolName: effectiveToolName,
priority: checker.priority,
checker: checker.checker as SafetyCheckerConfig,
modes: tier === 1 ? checker.modes : undefined,
modes: checker.modes,
};
if (argsPattern) {