MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-13 21:32:56 -07:00
Code Issues Packages Projects Releases Wiki Activity

Refine execution lifecycle facade follow-ups

Browse Source
This commit is contained in:
Adam Weidman
2026-03-09 00:14:48 -04:00
parent 1e872ead2d
commit 9b72826078
5 changed files with 93 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/services/executionLifecycleService.test.ts
+15
View File
@@ -133,6 +133,21 @@ describe('ExecutionLifecycleService', () => {
expect(result.error?.message).toContain('Operation cancelled by user');
});
it('does not probe OS process state for completed non-process execution IDs', async () => {
const handle = ExecutionLifecycleService.createExecution();
if (handle.pid === undefined) {
throw new Error('Expected execution ID.');
}
ExecutionLifecycleService.completeExecution(handle.pid, { exitCode: 0 });
await handle.result;
const processKillSpy = vi.spyOn(process, 'kill');
expect(ExecutionLifecycleService.isActive(handle.pid)).toBe(false);
expect(processKillSpy).not.toHaveBeenCalled();
processKillSpy.mockRestore();
});
it('manages external executions through registration hooks', async () => {
const writeInput = vi.fn();
const isActive = vi.fn().mockReturnValue(true);