MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-02 09:20:42 -07:00
Code Issues Packages Projects Releases Wiki Activity

don't confirm invalid params in terminal tool, or in general (added comments to base class) (#187)

Browse Source
This commit is contained in:
Olcan
2025-04-27 10:25:12 -07:00
committed by GitHub
parent 7828e813a8
commit 9de2e82b8f
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/server/src/tools/tools.ts
View File

@@ -36,6 +36,8 @@ export interface Tool<
/**
* Validates the parameters for the tool
* Should be called from both `shouldConfirmExecute` and `execute`
* `shouldConfirmExecute` should return false immediately if invalid
* @param params Parameters to validate
* @returns An error message string if invalid, null otherwise
*/
@@ -102,6 +104,8 @@ export abstract class BaseTool<
/**
* Validates the parameters for the tool
* This is a placeholder implementation and should be overridden
* Should be called from both `shouldConfirmExecute` and `execute`
* `shouldConfirmExecute` should return false immediately if invalid
* @param params Parameters to validate
* @returns An error message string if invalid, null otherwise
*/