Re-request consent if necessary when updating extensions (#9517)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

packages/cli/src/config/extensions/update.test.ts

@@ -140,6 +140,7 @@ describe('update tests', () => {
       const updateInfo = await updateExtension(
         extension,
         tempHomeDir,
+        async (_) => true,
         ExtensionUpdateState.UPDATE_AVAILABLE,
         () => {},
       );
@@ -197,6 +198,7 @@ describe('update tests', () => {
       await updateExtension(
         extension,
         tempHomeDir,
+        async (_) => true,
         ExtensionUpdateState.UPDATE_AVAILABLE,
         setExtensionUpdateState,
       );
@@ -239,6 +241,7 @@ describe('update tests', () => {
         updateExtension(
           extension,
           tempHomeDir,
+          async (_) => true,
           ExtensionUpdateState.UPDATE_AVAILABLE,
           setExtensionUpdateState,
         ),

packages/cli/src/config/extensions/update.ts

@@ -16,6 +16,7 @@ import {
   loadExtension,
   loadInstallMetadata,
   ExtensionStorage,
+  loadExtensionConfig,
 } from '../extension.js';
 import { checkForExtensionUpdate } from './github.js';
 
@@ -28,6 +29,7 @@ export interface ExtensionUpdateInfo {
 export async function updateExtension(
   extension: GeminiCLIExtension,
   cwd: string = process.cwd(),
+  requestConsent: (consent: string) => Promise<boolean>,
   currentState: ExtensionUpdateState,
   setExtensionUpdateState: (updateState: ExtensionUpdateState) => void,
 ): Promise<ExtensionUpdateInfo | undefined> {
@@ -52,8 +54,17 @@ export async function updateExtension(
   const tempDir = await ExtensionStorage.createTmpDir();
   try {
     await copyExtension(extension.path, tempDir);
+    const previousExtensionConfig = await loadExtensionConfig({
+      extensionDir: extension.path,
+      workspaceDir: cwd,
+    });
     await uninstallExtension(extension.name, cwd);
-    await installExtension(installMetadata, false, cwd);
+    await installExtension(
+      installMetadata,
+      requestConsent,
+      cwd,
+      previousExtensionConfig,
+    );
 
     const updatedExtensionStorage = new ExtensionStorage(extension.name);
     const updatedExtension = loadExtension({
@@ -85,6 +96,7 @@ export async function updateExtension(
 
 export async function updateAllUpdatableExtensions(
   cwd: string = process.cwd(),
+  requestConsent: (consent: string) => Promise<boolean>,
   extensions: GeminiCLIExtension[],
   extensionsState: Map<string, ExtensionUpdateState>,
   setExtensionsUpdateState: Dispatch<
@@ -103,6 +115,7 @@ export async function updateAllUpdatableExtensions(
           updateExtension(
             extension,
             cwd,
+            requestConsent,
             extensionsState.get(extension.name)!,
             (updateState) => {
               setExtensionsUpdateState((prev) => {