From a1559026f8e7cc61ff755c3e58b2bc50b3582e51 Mon Sep 17 00:00:00 2001 From: "A.K.M. Adib" Date: Mon, 26 Jan 2026 16:10:32 -0500 Subject: [PATCH] complete --- packages/core/src/config/config.test.ts | 6 ++++++ packages/core/src/config/config.ts | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/core/src/config/config.test.ts b/packages/core/src/config/config.test.ts index 2ee826c466..4f54e92555 100644 --- a/packages/core/src/config/config.test.ts +++ b/packages/core/src/config/config.test.ts @@ -1252,6 +1252,12 @@ describe('setApprovalMode with folder trust', () => { expect(() => config.setApprovalMode(ApprovalMode.DEFAULT)).not.toThrow(); }); + it('should NOT throw an error when setting PLAN mode in an untrusted folder', () => { + const config = new Config(baseParams); + vi.spyOn(config, 'isTrustedFolder').mockReturnValue(false); + expect(() => config.setApprovalMode(ApprovalMode.PLAN)).not.toThrow(); + }); + it('should NOT throw an error when setting any mode in a trusted folder', () => { const config = new Config(baseParams); vi.spyOn(config, 'isTrustedFolder').mockReturnValue(true); diff --git a/packages/core/src/config/config.ts b/packages/core/src/config/config.ts index 2dd235becf..03d0f3e6c7 100644 --- a/packages/core/src/config/config.ts +++ b/packages/core/src/config/config.ts @@ -1380,7 +1380,11 @@ export class Config { } setApprovalMode(mode: ApprovalMode): void { - if (!this.isTrustedFolder() && mode !== ApprovalMode.DEFAULT) { + if ( + !this.isTrustedFolder() && + mode !== ApprovalMode.DEFAULT && + mode !== ApprovalMode.PLAN + ) { throw new Error( 'Cannot enable privileged approval modes in an untrusted folder.', );