mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-05-14 05:42:54 -07:00
fix(bot): transition metrics to stable 7-day windows and stabilize build
This PR implements surgical fixes for identified issues in the repository metrics and build stability:
1. **Stable Metrics Windows**: Transitioned `throughput.ts`, `latency.ts`, and `user_touches.ts` from an unstable `last: 100` items window to a fixed 7-day search window. This resolves the "mathematically impossible" deltas identified in the bot's memory caused by bursty activity.
2. **Build Stabilization**:
- Upgraded `packages/test-utils/tsconfig.json` to `ES2023` to match the rest of the workspace and support modern features like `Object.hasOwn` and `Intl.Segmenter`.
- Added local `ErrorOptions` definitions in `a2a-errors.ts` and `fetch.ts` to support the `cause` property in `Error` constructors.
- Fixed an `err: unknown` type check issue in `packages/cli/index.ts`.
These changes ensure that the repository metrics are reliable and that the project build is stable for contributors.
cc @gundermanc
Labels: bot-fix
This commit is contained in:
@@ -2,25 +2,29 @@
|
||||
* @license
|
||||
* Copyright 2026 Google LLC
|
||||
* SPDX-License-Identifier: Apache-2.0
|
||||
*
|
||||
* @license
|
||||
*/
|
||||
|
||||
import { GITHUB_OWNER, GITHUB_REPO } from '../types.js';
|
||||
import { execSync } from 'node:child_process';
|
||||
|
||||
try {
|
||||
const sevenDaysAgo = new Date(Date.now() - 7 * 24 * 60 * 60 * 1000)
|
||||
.toISOString()
|
||||
.split('T')[0];
|
||||
|
||||
const query = `
|
||||
query($owner: String!, $repo: String!) {
|
||||
repository(owner: $owner, name: $repo) {
|
||||
pullRequests(last: 100, states: MERGED) {
|
||||
nodes {
|
||||
query($owner: String!, $repo: String!, $prQ: String!, $issueQ: String!) {
|
||||
pullRequests: search(query: $prQ, type: ISSUE, first: 100) {
|
||||
nodes {
|
||||
... on PullRequest {
|
||||
authorAssociation
|
||||
mergedAt
|
||||
}
|
||||
}
|
||||
issues(last: 100, states: CLOSED) {
|
||||
nodes {
|
||||
}
|
||||
issues: search(query: $issueQ, type: ISSUE, first: 100) {
|
||||
nodes {
|
||||
... on Issue {
|
||||
authorAssociation
|
||||
closedAt
|
||||
}
|
||||
@@ -28,25 +32,29 @@ try {
|
||||
}
|
||||
}
|
||||
`;
|
||||
|
||||
const prQ = `repo:${GITHUB_OWNER}/${GITHUB_REPO} is:pr is:merged merged:>${sevenDaysAgo}`;
|
||||
const issueQ = `repo:${GITHUB_OWNER}/${GITHUB_REPO} is:issue is:closed closed:>${sevenDaysAgo}`;
|
||||
|
||||
const output = execSync(
|
||||
`gh api graphql -F owner=${GITHUB_OWNER} -F repo=${GITHUB_REPO} -f query='${query}'`,
|
||||
`gh api graphql -F owner=${GITHUB_OWNER} -F repo=${GITHUB_REPO} -F prQ='${prQ}' -F issueQ='${issueQ}' -f query='${query}'`,
|
||||
{ encoding: 'utf-8' },
|
||||
);
|
||||
const data = JSON.parse(output).data.repository;
|
||||
const data = JSON.parse(output).data;
|
||||
|
||||
const prs = data.pullRequests.nodes
|
||||
.map((p: { authorAssociation: string; mergedAt: string }) => ({
|
||||
const prs = data.pullRequests.nodes.map(
|
||||
(p: { authorAssociation: string; mergedAt: string }) => ({
|
||||
association: p.authorAssociation,
|
||||
date: new Date(p.mergedAt).getTime(),
|
||||
}))
|
||||
.sort((a: { date: number }, b: { date: number }) => a.date - b.date);
|
||||
}),
|
||||
);
|
||||
|
||||
const issues = data.issues.nodes
|
||||
.map((i: { authorAssociation: string; closedAt: string }) => ({
|
||||
const issues = data.issues.nodes.map(
|
||||
(i: { authorAssociation: string; closedAt: string }) => ({
|
||||
association: i.authorAssociation,
|
||||
date: new Date(i.closedAt).getTime(),
|
||||
}))
|
||||
.sort((a: { date: number }, b: { date: number }) => a.date - b.date);
|
||||
}),
|
||||
);
|
||||
|
||||
const isMaintainer = (assoc: string) =>
|
||||
['MEMBER', 'OWNER', 'COLLABORATOR'].includes(assoc);
|
||||
@@ -54,11 +62,7 @@ try {
|
||||
const calculateThroughput = (
|
||||
items: { association: string; date: number }[],
|
||||
) => {
|
||||
if (items.length < 2) return 0;
|
||||
const first = items[0].date;
|
||||
const last = items[items.length - 1].date;
|
||||
const days = (last - first) / (1000 * 60 * 60 * 24);
|
||||
return days > 0 ? items.length / days : items.length; // items per day
|
||||
return items.length / 7; // items per day over 7 day window
|
||||
};
|
||||
|
||||
const prOverall = calculateThroughput(prs);
|
||||
|
||||
Reference in New Issue
Block a user