feat(core): improve subagent result display (#20378)

2026-04-25 20:44:46 -07:00 · 2026-03-09 12:20:15 -07:00
parent d246315cea
commit a17691f0fc
21 changed files with 925 additions and 238 deletions
@@ -0,0 +1,101 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import { renderWithProviders } from '../../../test-utils/render.js';
+import { ToolResultDisplay } from './ToolResultDisplay.js';
+import { describe, it, expect } from 'vitest';
+import { type AnsiOutput } from '@google/gemini-cli-core';
+
+describe('ToolResultDisplay Overflow', () => {
+  it('shows the head of the content when overflowDirection is bottom (string)', async () => {
+    const content = 'Line 1\nLine 2\nLine 3\nLine 4\nLine 5';
+    const { lastFrame, waitUntilReady, unmount } = renderWithProviders(
+      <ToolResultDisplay
+        resultDisplay={content}
+        terminalWidth={80}
+        maxLines={3}
+        overflowDirection="bottom"
+      />,
+      {
+        useAlternateBuffer: false,
+        uiState: { constrainHeight: true },
+      },
+    );
+    await waitUntilReady();
+    const output = lastFrame();
+
+    expect(output).toContain('Line 1');
+    expect(output).toContain('Line 2');
+    expect(output).not.toContain('Line 3'); // Line 3 is replaced by the "hidden" label
+    expect(output).not.toContain('Line 4');
+    expect(output).not.toContain('Line 5');
+    expect(output).toContain('hidden');
+    unmount();
+  });
+
+  it('shows the tail of the content when overflowDirection is top (string default)', async () => {
+    const content = 'Line 1\nLine 2\nLine 3\nLine 4\nLine 5';
+    const { lastFrame, waitUntilReady, unmount } = renderWithProviders(
+      <ToolResultDisplay
+        resultDisplay={content}
+        terminalWidth={80}
+        maxLines={3}
+        overflowDirection="top"
+      />,
+      {
+        useAlternateBuffer: false,
+        uiState: { constrainHeight: true },
+      },
+    );
+    await waitUntilReady();
+    const output = lastFrame();
+
+    expect(output).not.toContain('Line 1');
+    expect(output).not.toContain('Line 2');
+    expect(output).not.toContain('Line 3');
+    expect(output).toContain('Line 4');
+    expect(output).toContain('Line 5');
+    expect(output).toContain('hidden');
+    unmount();
+  });
+
+  it('shows the head of the content when overflowDirection is bottom (ANSI)', async () => {
+    const ansiResult: AnsiOutput = Array.from({ length: 5 }, (_, i) => [
+      {
+        text: `Line ${i + 1}`,
+        fg: '',
+        bg: '',
+        bold: false,
+        italic: false,
+        underline: false,
+        dim: false,
+        inverse: false,
+      },
+    ]);
+    const { lastFrame, waitUntilReady, unmount } = renderWithProviders(
+      <ToolResultDisplay
+        resultDisplay={ansiResult}
+        terminalWidth={80}
+        maxLines={3}
+        overflowDirection="bottom"
+      />,
+      {
+        useAlternateBuffer: false,
+        uiState: { constrainHeight: true },
+      },
+    );
+    await waitUntilReady();
+    const output = lastFrame();
+
+    expect(output).toContain('Line 1');
+    expect(output).toContain('Line 2');
+    expect(output).not.toContain('Line 3');
+    expect(output).not.toContain('Line 4');
+    expect(output).not.toContain('Line 5');
+    expect(output).toContain('hidden');
+    unmount();
+  });
+});