Code review fixes for show question mark pr. (#18480)

This commit is contained in:
Jacob Richman
2026-02-06 22:35:14 -08:00
committed by GitHub
parent 6f1a5bf81d
commit a37844e5a1
11 changed files with 298 additions and 235 deletions
@@ -0,0 +1,49 @@
/**
* @license
* Copyright 2025 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/
import { describe, it, expect, afterEach, vi } from 'vitest';
import { renderWithProviders } from '../../test-utils/render.js';
import { ShortcutsHelp } from './ShortcutsHelp.js';
describe('ShortcutsHelp', () => {
const originalPlatform = process.platform;
afterEach(() => {
Object.defineProperty(process, 'platform', {
value: originalPlatform,
});
vi.restoreAllMocks();
});
const testCases = [
{ name: 'wide', width: 100 },
{ name: 'narrow', width: 40 },
];
const platforms = [
{ name: 'mac', value: 'darwin' },
{ name: 'linux', value: 'linux' },
] as const;
it.each(
platforms.flatMap((platform) =>
testCases.map((testCase) => ({ ...testCase, platform })),
),
)(
'renders correctly in $name mode on $platform.name',
({ width, platform }) => {
Object.defineProperty(process, 'platform', {
value: platform.value,
});
const { lastFrame } = renderWithProviders(<ShortcutsHelp />, {
width,
});
expect(lastFrame()).toContain('shell mode');
expect(lastFrame()).toMatchSnapshot();
},
);
});