MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-02 09:20:42 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug executing commands in windows whose flags contain spaces (#5317)

Browse Source
This commit is contained in:
Tommaso Sciortino
2025-07-31 17:27:07 -07:00
committed by GitHub
parent 6f7beb414c
commit a3a432e3cf
2 changed files with 26 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/core/src/services/shellExecutionService.ts
View File

@@ -89,13 +89,16 @@ export class ShellExecutionService {
abortSignal: AbortSignal,
): ShellExecutionHandle {
const isWindows = os.platform() === 'win32';
const shell = isWindows ? 'cmd.exe' : 'bash';
const shellArgs = [isWindows ? '/c' : '-c', commandToExecute];
const child = spawn(shell, shellArgs, {
const child = spawn(commandToExecute, [], {
cwd,
stdio: ['ignore', 'pipe', 'pipe'],
detached: !isWindows, // Use process groups on non-Windows for robust killing
// Use bash unless in Windows (since it doesn't support bash).
// For windows, just use the default.
shell: isWindows ? true : 'bash',
// Use process groups on non-Windows for robust killing.
// Windows process termination is handled by `taskkill /t`.
detached: !isWindows,
env: {
...process.env,
GEMINI_CLI: '1',