diff --git a/packages/cli/src/ui/App.test.tsx b/packages/cli/src/ui/App.test.tsx index 969e8b23aa..4e59ab854e 100644 --- a/packages/cli/src/ui/App.test.tsx +++ b/packages/cli/src/ui/App.test.tsx @@ -99,9 +99,7 @@ describe('App', () => { { uiState: mockUIState, config: makeFakeConfig({ useAlternateBuffer: false }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: false } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: false } }), }, ); await waitUntilReady(); @@ -123,9 +121,7 @@ describe('App', () => { { uiState: quittingUIState, config: makeFakeConfig({ useAlternateBuffer: false }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: false } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: false } }), }, ); await waitUntilReady(); @@ -147,9 +143,7 @@ describe('App', () => { { uiState: quittingUIState, config: makeFakeConfig({ useAlternateBuffer: true }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: true } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), }, ); await waitUntilReady(); @@ -170,9 +164,7 @@ describe('App', () => { { uiState: dialogUIState, config: makeFakeConfig({ useAlternateBuffer: true }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: true } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), }, ); await waitUntilReady(); @@ -200,9 +192,7 @@ describe('App', () => { { uiState, config: makeFakeConfig({ useAlternateBuffer: true }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: true } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), }, ); await waitUntilReady(); @@ -220,9 +210,7 @@ describe('App', () => { { uiState: mockUIState, config: makeFakeConfig({ useAlternateBuffer: true }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: true } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), }, ); await waitUntilReady(); @@ -242,9 +230,7 @@ describe('App', () => { { uiState: mockUIState, config: makeFakeConfig({ useAlternateBuffer: true }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: true } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), }, ); await waitUntilReady(); @@ -300,9 +286,7 @@ describe('App', () => { { uiState: stateWithConfirmingTool, config: configWithExperiment, - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: true } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), }, ); await waitUntilReady(); @@ -323,9 +307,7 @@ describe('App', () => { { uiState: mockUIState, config: makeFakeConfig({ useAlternateBuffer: true }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: true } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), }, ); await waitUntilReady(); @@ -340,9 +322,7 @@ describe('App', () => { { uiState: mockUIState, config: makeFakeConfig({ useAlternateBuffer: true }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: true } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), }, ); await waitUntilReady(); @@ -360,9 +340,7 @@ describe('App', () => { { uiState: dialogUIState, config: makeFakeConfig({ useAlternateBuffer: true }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: true } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), }, ); await waitUntilReady(); diff --git a/packages/cli/src/ui/AppContainer.test.tsx b/packages/cli/src/ui/AppContainer.test.tsx index 26ee1a87c1..3e420f141d 100644 --- a/packages/cli/src/ui/AppContainer.test.tsx +++ b/packages/cli/src/ui/AppContainer.test.tsx @@ -486,17 +486,15 @@ describe('AppContainer State Management', () => { // Mock LoadedSettings mockSettings = createMockSettings({ - merged: { - hideBanner: false, - hideFooter: false, - hideTips: false, - showMemoryUsage: false, - theme: 'default', - ui: { - showStatusInTitle: false, - hideWindowTitle: false, - useAlternateBuffer: false, - }, + hideBanner: false, + hideFooter: false, + hideTips: false, + showMemoryUsage: false, + theme: 'default', + ui: { + showStatusInTitle: false, + hideWindowTitle: false, + useAlternateBuffer: false, }, }); @@ -1007,12 +1005,10 @@ describe('AppContainer State Management', () => { describe('Settings Integration', () => { it('handles settings with all display options disabled', async () => { const settingsAllHidden = createMockSettings({ - merged: { - hideBanner: true, - hideFooter: true, - hideTips: true, - showMemoryUsage: false, - }, + hideBanner: true, + hideFooter: true, + hideTips: true, + showMemoryUsage: false, }); let unmount: () => void; @@ -1026,9 +1022,7 @@ describe('AppContainer State Management', () => { it('handles settings with memory usage enabled', async () => { const settingsWithMemory = createMockSettings({ - merged: { - showMemoryUsage: true, - }, + showMemoryUsage: true, }); let unmount: () => void; @@ -1488,11 +1482,9 @@ describe('AppContainer State Management', () => { it('should update terminal title with Working… when showStatusInTitle is false', () => { // Arrange: Set up mock settings with showStatusInTitle disabled const mockSettingsWithShowStatusFalse = createMockSettings({ - merged: { - ui: { - showStatusInTitle: false, - hideWindowTitle: false, - }, + ui: { + showStatusInTitle: false, + hideWindowTitle: false, }, }); @@ -1523,11 +1515,9 @@ describe('AppContainer State Management', () => { it('should use legacy terminal title when dynamicWindowTitle is false', () => { // Arrange: Set up mock settings with dynamicWindowTitle disabled const mockSettingsWithDynamicTitleFalse = createMockSettings({ - merged: { - ui: { - dynamicWindowTitle: false, - hideWindowTitle: false, - }, + ui: { + dynamicWindowTitle: false, + hideWindowTitle: false, }, }); @@ -1558,11 +1548,9 @@ describe('AppContainer State Management', () => { it('should not update terminal title when hideWindowTitle is true', () => { // Arrange: Set up mock settings with hideWindowTitle enabled const mockSettingsWithHideTitleTrue = createMockSettings({ - merged: { - ui: { - showStatusInTitle: true, - hideWindowTitle: true, - }, + ui: { + showStatusInTitle: true, + hideWindowTitle: true, }, }); @@ -1583,11 +1571,9 @@ describe('AppContainer State Management', () => { it('should update terminal title with thought subject when in active state', () => { // Arrange: Set up mock settings with showStatusInTitle enabled const mockSettingsWithTitleEnabled = createMockSettings({ - merged: { - ui: { - showStatusInTitle: true, - hideWindowTitle: false, - }, + ui: { + showStatusInTitle: true, + hideWindowTitle: false, }, }); @@ -1619,11 +1605,9 @@ describe('AppContainer State Management', () => { it('should update terminal title with default text when in Idle state and no thought subject', () => { // Arrange: Set up mock settings with showStatusInTitle enabled const mockSettingsWithTitleEnabled = createMockSettings({ - merged: { - ui: { - showStatusInTitle: true, - hideWindowTitle: false, - }, + ui: { + showStatusInTitle: true, + hideWindowTitle: false, }, }); @@ -1650,11 +1634,9 @@ describe('AppContainer State Management', () => { it('should update terminal title when in WaitingForConfirmation state with thought subject', async () => { // Arrange: Set up mock settings with showStatusInTitle enabled const mockSettingsWithTitleEnabled = createMockSettings({ - merged: { - ui: { - showStatusInTitle: true, - hideWindowTitle: false, - }, + ui: { + showStatusInTitle: true, + hideWindowTitle: false, }, }); @@ -1709,11 +1691,9 @@ describe('AppContainer State Management', () => { // Arrange: Set up mock settings with showStatusInTitle enabled const mockSettingsWithTitleEnabled = createMockSettings({ - merged: { - ui: { - showStatusInTitle: true, - hideWindowTitle: false, - }, + ui: { + showStatusInTitle: true, + hideWindowTitle: false, }, }); @@ -1765,11 +1745,9 @@ describe('AppContainer State Management', () => { // Arrange: Set up mock settings with showStatusInTitle enabled const mockSettingsWithTitleEnabled = createMockSettings({ - merged: { - ui: { - showStatusInTitle: true, - hideWindowTitle: false, - }, + ui: { + showStatusInTitle: true, + hideWindowTitle: false, }, }); @@ -1832,11 +1810,9 @@ describe('AppContainer State Management', () => { // Arrange: Set up mock settings with showStatusInTitle enabled const mockSettingsWithTitleEnabled = createMockSettings({ - merged: { - ui: { - showStatusInTitle: true, - hideWindowTitle: false, - }, + ui: { + showStatusInTitle: true, + hideWindowTitle: false, }, }); @@ -1879,11 +1855,9 @@ describe('AppContainer State Management', () => { // Arrange: Set up mock settings with showStatusInTitle enabled const mockSettingsWithTitleEnabled = createMockSettings({ - merged: { - ui: { - showStatusInTitle: true, - hideWindowTitle: false, - }, + ui: { + showStatusInTitle: true, + hideWindowTitle: false, }, }); @@ -1960,11 +1934,9 @@ describe('AppContainer State Management', () => { it('should pad title to exactly 80 characters', () => { // Arrange: Set up mock settings with showStatusInTitle enabled const mockSettingsWithTitleEnabled = createMockSettings({ - merged: { - ui: { - showStatusInTitle: true, - hideWindowTitle: false, - }, + ui: { + showStatusInTitle: true, + hideWindowTitle: false, }, }); @@ -1997,11 +1969,9 @@ describe('AppContainer State Management', () => { it('should use correct ANSI escape code format', () => { // Arrange: Set up mock settings with showStatusInTitle enabled const mockSettingsWithTitleEnabled = createMockSettings({ - merged: { - ui: { - showStatusInTitle: true, - hideWindowTitle: false, - }, + ui: { + showStatusInTitle: true, + hideWindowTitle: false, }, }); @@ -2032,11 +2002,9 @@ describe('AppContainer State Management', () => { it('should use CLI_TITLE environment variable when set', () => { // Arrange: Set up mock settings with showStatusInTitle disabled (so it shows suffix) const mockSettingsWithTitleDisabled = createMockSettings({ - merged: { - ui: { - showStatusInTitle: false, - hideWindowTitle: false, - }, + ui: { + showStatusInTitle: false, + hideWindowTitle: false, }, }); @@ -2608,11 +2576,7 @@ describe('AppContainer State Management', () => { // Update settings for this test run const testSettings = createMockSettings({ - merged: { - ui: { - useAlternateBuffer: isAlternateMode, - }, - }, + ui: { useAlternateBuffer: isAlternateMode }, }); function TestChild() { @@ -3323,11 +3287,7 @@ describe('AppContainer State Management', () => { let unmount: () => void; await act(async () => { unmount = renderAppContainer({ - settings: createMockSettings({ - merged: { - ui: { useAlternateBuffer: false }, - }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: false } }), }).unmount; }); @@ -3363,11 +3323,7 @@ describe('AppContainer State Management', () => { let unmount: () => void; await act(async () => { unmount = renderAppContainer({ - settings: createMockSettings({ - merged: { - ui: { useAlternateBuffer: true }, - }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), }).unmount; }); @@ -3637,11 +3593,7 @@ describe('AppContainer State Management', () => { it('DOES set showIsExpandableHint when overflow occurs in Alternate Buffer Mode', async () => { const settingsWithAlternateBuffer = createMockSettings({ - merged: { - ui: { - useAlternateBuffer: true, - }, - }, + ui: { useAlternateBuffer: true }, }); vi.spyOn(mockConfig, 'getUseAlternateBuffer').mockReturnValue(true); diff --git a/packages/cli/src/ui/components/AskUserDialog.test.tsx b/packages/cli/src/ui/components/AskUserDialog.test.tsx index 2f4f711e75..67289769be 100644 --- a/packages/cli/src/ui/components/AskUserDialog.test.tsx +++ b/packages/cli/src/ui/components/AskUserDialog.test.tsx @@ -317,9 +317,7 @@ describe('AskUserDialog', () => { />, { config: makeFakeConfig({ useAlternateBuffer }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer } }), }, ); @@ -1300,9 +1298,7 @@ describe('AskUserDialog', () => { , { config: makeFakeConfig({ useAlternateBuffer: false }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: false } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: false } }), }, ); @@ -1341,9 +1337,7 @@ describe('AskUserDialog', () => { , { config: makeFakeConfig({ useAlternateBuffer: true }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: true } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), }, ); diff --git a/packages/cli/src/ui/components/Composer.test.tsx b/packages/cli/src/ui/components/Composer.test.tsx index 84f8d15a06..e0919947fb 100644 --- a/packages/cli/src/ui/components/Composer.test.tsx +++ b/packages/cli/src/ui/components/Composer.test.tsx @@ -408,7 +408,7 @@ describe('Composer', () => { thought: { subject: 'Hidden', description: 'Should not show' }, }); const settings = createMockSettings({ - merged: { ui: { loadingPhrases: 'off' } }, + ui: { loadingPhrases: 'off' }, }); const { lastFrame } = await renderComposer(uiState, settings); diff --git a/packages/cli/src/ui/components/DetailedMessagesDisplay.test.tsx b/packages/cli/src/ui/components/DetailedMessagesDisplay.test.tsx index 65d54e50d6..b6fd50b33f 100644 --- a/packages/cli/src/ui/components/DetailedMessagesDisplay.test.tsx +++ b/packages/cli/src/ui/components/DetailedMessagesDisplay.test.tsx @@ -38,9 +38,7 @@ describe('DetailedMessagesDisplay', () => { hasFocus={false} />, { - settings: createMockSettings({ - merged: { ui: { errorVerbosity: 'full' } }, - }), + settings: createMockSettings({ ui: { errorVerbosity: 'full' } }), }, ); await waitUntilReady(); @@ -64,9 +62,7 @@ describe('DetailedMessagesDisplay', () => { hasFocus={true} />, { - settings: createMockSettings({ - merged: { ui: { errorVerbosity: 'full' } }, - }), + settings: createMockSettings({ ui: { errorVerbosity: 'full' } }), }, ); await waitUntilReady(); @@ -89,9 +85,7 @@ describe('DetailedMessagesDisplay', () => { hasFocus={true} />, { - settings: createMockSettings({ - merged: { ui: { errorVerbosity: 'low' } }, - }), + settings: createMockSettings({ ui: { errorVerbosity: 'low' } }), }, ); await waitUntilReady(); @@ -112,9 +106,7 @@ describe('DetailedMessagesDisplay', () => { hasFocus={true} />, { - settings: createMockSettings({ - merged: { ui: { errorVerbosity: 'full' } }, - }), + settings: createMockSettings({ ui: { errorVerbosity: 'full' } }), }, ); await waitUntilReady(); @@ -135,9 +127,7 @@ describe('DetailedMessagesDisplay', () => { hasFocus={false} />, { - settings: createMockSettings({ - merged: { ui: { errorVerbosity: 'full' } }, - }), + settings: createMockSettings({ ui: { errorVerbosity: 'full' } }), }, ); await waitUntilReady(); diff --git a/packages/cli/src/ui/components/ExitPlanModeDialog.test.tsx b/packages/cli/src/ui/components/ExitPlanModeDialog.test.tsx index 272ccbdc27..231d5f102f 100644 --- a/packages/cli/src/ui/components/ExitPlanModeDialog.test.tsx +++ b/packages/cli/src/ui/components/ExitPlanModeDialog.test.tsx @@ -167,9 +167,7 @@ Implement a comprehensive authentication system with multiple providers. }), getUseAlternateBuffer: () => useAlternateBuffer, } as unknown as import('@google/gemini-cli-core').Config, - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer } }), }, ); }; @@ -449,9 +447,7 @@ Implement a comprehensive authentication system with multiple providers. getUseAlternateBuffer: () => useAlternateBuffer ?? true, } as unknown as import('@google/gemini-cli-core').Config, settings: createMockSettings({ - merged: { - ui: { useAlternateBuffer: useAlternateBuffer ?? true }, - }, + ui: { useAlternateBuffer: useAlternateBuffer ?? true }, }), }, ); diff --git a/packages/cli/src/ui/components/FolderTrustDialog.test.tsx b/packages/cli/src/ui/components/FolderTrustDialog.test.tsx index 0ff0e9b0df..9ad4fac02d 100644 --- a/packages/cli/src/ui/components/FolderTrustDialog.test.tsx +++ b/packages/cli/src/ui/components/FolderTrustDialog.test.tsx @@ -80,9 +80,7 @@ describe('FolderTrustDialog', () => { { width: 80, config: makeFakeConfig({ useAlternateBuffer: false }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: false } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: false } }), uiState: { constrainHeight: true, terminalHeight: 24 }, }, ); @@ -113,9 +111,7 @@ describe('FolderTrustDialog', () => { { width: 80, config: makeFakeConfig({ useAlternateBuffer: false }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: false } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: false } }), uiState: { constrainHeight: true, terminalHeight: 14 }, }, ); @@ -147,9 +143,7 @@ describe('FolderTrustDialog', () => { { width: 80, config: makeFakeConfig({ useAlternateBuffer: false }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: false } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: false } }), uiState: { constrainHeight: true, terminalHeight: 10 }, }, ); @@ -179,9 +173,7 @@ describe('FolderTrustDialog', () => { { width: 80, config: makeFakeConfig({ useAlternateBuffer: false }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: false } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: false } }), // Initially constrained uiState: { constrainHeight: true, terminalHeight: 24 }, }, @@ -208,9 +200,7 @@ describe('FolderTrustDialog', () => { { width: 80, config: makeFakeConfig({ useAlternateBuffer: false }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: false } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: false } }), uiState: { constrainHeight: false, terminalHeight: 24 }, }, ); @@ -451,9 +441,7 @@ describe('FolderTrustDialog', () => { { width: 80, config: makeFakeConfig({ useAlternateBuffer: true }), - settings: createMockSettings({ - merged: { ui: { useAlternateBuffer: true } }, - }), + settings: createMockSettings({ ui: { useAlternateBuffer: true } }), uiState: { constrainHeight: false, terminalHeight: 15 }, }, ); diff --git a/packages/cli/src/ui/components/Footer.test.tsx b/packages/cli/src/ui/components/Footer.test.tsx index ab487a440f..84782b2513 100644 --- a/packages/cli/src/ui/components/Footer.test.tsx +++ b/packages/cli/src/ui/components/Footer.test.tsx @@ -673,9 +673,7 @@ describe('