MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-13 14:50:39 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): override j/k navigation in settings dialog to fix search input conflict (#22800)

Browse Source
This commit is contained in:
Sehoon Shon
2026-03-17 15:08:45 -04:00
committed by GitHub
parent fc51e50bc6
commit b211f30d95
3 changed files with 57 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
packages/cli/src/ui/components/SettingsDialog.test.tsx
View File

@@ -52,6 +52,8 @@ enum TerminalKeys {
RIGHT_ARROW = '\u001B[C',
ESCAPE = '\u001B',
BACKSPACE = '\u0008',
CTRL_P = '\u0010',
CTRL_N = '\u000E',
}
vi.mock('../../config/settingsSchema.js', async (importOriginal) => {
@@ -357,9 +359,9 @@ describe('SettingsDialog', () => {
up: TerminalKeys.UP_ARROW,
},
{
name: 'vim keys (j/k)',
down: 'j',
up: 'k',
name: 'emacs keys (Ctrl+P/N)',
down: TerminalKeys.CTRL_N,
up: TerminalKeys.CTRL_P,
},
])('should navigate with $name', async ({ down, up }) => {
const settings = createMockSettings();
@@ -397,6 +399,31 @@ describe('SettingsDialog', () => {
unmount();
});
it('should allow j and k characters to be typed in search without triggering navigation', async () => {
const settings = createMockSettings();
const onSelect = vi.fn();
const { lastFrame, stdin, waitUntilReady, unmount } = renderDialog(
settings,
onSelect,
);
await waitUntilReady();
// Enter 'j' and 'k' in search
await act(async () => stdin.write('j'));
await waitUntilReady();
await act(async () => stdin.write('k'));
await waitUntilReady();
await waitFor(() => {
const frame = lastFrame();
// The search box should contain 'jk'
expect(frame).toContain('jk');
// Since 'jk' doesn't match any setting labels, it should say "No matches found."
expect(frame).toContain('No matches found.');
});
unmount();
});
it('wraps around when at the top of the list', async () => {
const settings = createMockSettings();
const onSelect = vi.fn();