fix: Exit app on pressing esc on trust dialog at launch (#10668)

This commit is contained in:
shrutip90
2025-10-14 07:27:40 -07:00
committed by GitHub
parent 249a193c00
commit b2ba67f337
2 changed files with 25 additions and 20 deletions
@@ -7,7 +7,7 @@
import { renderWithProviders } from '../../test-utils/render.js';
import { waitFor } from '@testing-library/react';
import { vi } from 'vitest';
import { FolderTrustDialog, FolderTrustChoice } from './FolderTrustDialog.js';
import { FolderTrustDialog } from './FolderTrustDialog.js';
import * as processUtils from '../../utils/processUtils.js';
vi.mock('../../utils/processUtils.js', () => ({
@@ -44,30 +44,23 @@ describe('FolderTrustDialog', () => {
);
});
it('should call onSelect with DO_NOT_TRUST when escape is pressed and not restarting', async () => {
it('should display exit message and call process.exit and not call onSelect when escape is pressed', async () => {
const onSelect = vi.fn();
const { stdin } = renderWithProviders(
const { lastFrame, stdin } = renderWithProviders(
<FolderTrustDialog onSelect={onSelect} isRestarting={false} />,
);
stdin.write('\x1b'); // escape key
await waitFor(() => {
expect(onSelect).toHaveBeenCalledWith(FolderTrustChoice.DO_NOT_TRUST);
expect(lastFrame()).toContain(
'A folder trust level must be selected to continue. Exiting since escape was pressed.',
);
});
});
it('should not call onSelect when escape is pressed and is restarting', async () => {
const onSelect = vi.fn();
const { stdin } = renderWithProviders(
<FolderTrustDialog onSelect={onSelect} isRestarting={true} />,
);
stdin.write('\x1b'); // escape key
await waitFor(() => {
expect(onSelect).not.toHaveBeenCalled();
expect(mockedExit).toHaveBeenCalledWith(1);
});
expect(onSelect).not.toHaveBeenCalled();
});
it('should display restart message when isRestarting is true', () => {
@@ -84,7 +77,7 @@ describe('FolderTrustDialog', () => {
renderWithProviders(
<FolderTrustDialog onSelect={vi.fn()} isRestarting={true} />,
);
await vi.advanceTimersByTimeAsync(1000);
await vi.advanceTimersByTimeAsync(250);
expect(relaunchApp).toHaveBeenCalled();
vi.useRealTimers();
});