fix(core)!: Force policy config to specify toolName (#23330)

This commit is contained in:
Keith Schaab
2026-03-23 22:35:08 +00:00
committed by GitHub
parent 2a18e78611
commit b35c12d8d0
18 changed files with 224 additions and 64 deletions
@@ -760,6 +760,7 @@ describe('policy.ts', () => {
(mockConfig as unknown as { config: Config }).config = mockConfig;
const rule = {
toolName: '*',
decision: PolicyDecision.DENY,
denyMessage: 'Custom Deny',
};
@@ -642,6 +642,7 @@ describe('Scheduler (Orchestrator)', () => {
vi.mocked(checkPolicy).mockResolvedValue({
decision: PolicyDecision.DENY,
rule: {
toolName: '*',
decision: PolicyDecision.DENY,
denyMessage: 'Custom denial reason',
},
@@ -693,7 +694,7 @@ describe('Scheduler (Orchestrator)', () => {
it('should return POLICY_VIOLATION error type when denied in Plan Mode', async () => {
vi.mocked(checkPolicy).mockResolvedValue({
decision: PolicyDecision.DENY,
rule: { decision: PolicyDecision.DENY },
rule: { toolName: '*', decision: PolicyDecision.DENY },
});
mockConfig.getApprovalMode.mockReturnValue(ApprovalMode.PLAN);
@@ -722,7 +723,11 @@ describe('Scheduler (Orchestrator)', () => {
const customMessage = 'Custom Plan Mode Deny';
vi.mocked(checkPolicy).mockResolvedValue({
decision: PolicyDecision.DENY,
rule: { decision: PolicyDecision.DENY, denyMessage: customMessage },
rule: {
toolName: '*',
decision: PolicyDecision.DENY,
denyMessage: customMessage,
},
});
mockConfig.getApprovalMode.mockReturnValue(ApprovalMode.PLAN);