MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-30 06:54:15 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): use getDisplayString for manual model selection in dialog (#19726)

Browse Source
This commit is contained in:
Sehoon Shon
2026-02-20 17:03:32 -05:00
committed by GitHub
parent 9a8e5d3940
commit b48970da15
2 changed files with 25 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/ui/components/ModelDialog.test.tsx
+19 -6
View File
@@ -109,7 +109,15 @@ describe('<ModelDialog />', () => {
unmount(); unmount();
}); });
it('switches to "manual" view when "Manual" is selected', async () => { it('switches to "manual" view when "Manual" is selected and uses getDisplayString for models', async () => {
mockGetDisplayString.mockImplementation((val: string) => {
if (val === DEFAULT_GEMINI_MODEL) return 'Formatted Pro Model';
if (val === DEFAULT_GEMINI_FLASH_MODEL) return 'Formatted Flash Model';
if (val === DEFAULT_GEMINI_FLASH_LITE_MODEL)
return 'Formatted Lite Model';
return val;
});
const { lastFrame, stdin, waitUntilReady, unmount } = const { lastFrame, stdin, waitUntilReady, unmount } =
await renderComponent(); await renderComponent();
@@ -129,9 +137,9 @@ describe('<ModelDialog />', () => {
// Should now show manual options // Should now show manual options
await waitFor(() => { await waitFor(() => {
const output = lastFrame(); const output = lastFrame();
expect(output).toContain(DEFAULT_GEMINI_MODEL); expect(output).toContain('Formatted Pro Model');
expect(output).toContain(DEFAULT_GEMINI_FLASH_MODEL); expect(output).toContain('Formatted Flash Model');
expect(output).toContain(DEFAULT_GEMINI_FLASH_LITE_MODEL); expect(output).toContain('Formatted Lite Model');
}); });
unmount(); unmount();
}); });
@@ -264,11 +272,16 @@ describe('<ModelDialog />', () => {
unmount(); unmount();
}); });
it('shows the preferred manual model in the main view option', async () => { it('shows the preferred manual model in the main view option using getDisplayString', async () => {
mockGetModel.mockReturnValue(DEFAULT_GEMINI_MODEL); mockGetModel.mockReturnValue(DEFAULT_GEMINI_MODEL);
mockGetDisplayString.mockImplementation((val: string) => {
if (val === DEFAULT_GEMINI_MODEL) return 'My Custom Model Display';
if (val === 'auto-gemini-2.5') return 'Auto (Gemini 2.5)';
return val;
});
const { lastFrame, unmount } = await renderComponent(); const { lastFrame, unmount } = await renderComponent();
expect(lastFrame()).toContain(`Manual (${DEFAULT_GEMINI_MODEL})`); expect(lastFrame()).toContain('Manual (My Custom Model Display)');
unmount(); unmount();
}); });
packages/cli/src/ui/components/ModelDialog.tsx
+6 -6
View File
@@ -94,7 +94,7 @@ export function ModelDialog({ onClose }: ModelDialogProps): React.JSX.Element {
{ {
value: 'Manual', value: 'Manual',
title: manualModelSelected title: manualModelSelected
? `Manual (${manualModelSelected})` ? `Manual (${getDisplayString(manualModelSelected)})`
: 'Manual', : 'Manual',
description: 'Manually select a model', description: 'Manually select a model',
key: 'Manual', key: 'Manual',
@@ -118,17 +118,17 @@ export function ModelDialog({ onClose }: ModelDialogProps): React.JSX.Element {
const list = [ const list = [
{ {
value: DEFAULT_GEMINI_MODEL, value: DEFAULT_GEMINI_MODEL,
title: DEFAULT_GEMINI_MODEL, title: getDisplayString(DEFAULT_GEMINI_MODEL),
key: DEFAULT_GEMINI_MODEL, key: DEFAULT_GEMINI_MODEL,
}, },
{ {
value: DEFAULT_GEMINI_FLASH_MODEL, value: DEFAULT_GEMINI_FLASH_MODEL,
title: DEFAULT_GEMINI_FLASH_MODEL, title: getDisplayString(DEFAULT_GEMINI_FLASH_MODEL),
key: DEFAULT_GEMINI_FLASH_MODEL, key: DEFAULT_GEMINI_FLASH_MODEL,
}, },
{ {
value: DEFAULT_GEMINI_FLASH_LITE_MODEL, value: DEFAULT_GEMINI_FLASH_LITE_MODEL,
title: DEFAULT_GEMINI_FLASH_LITE_MODEL, title: getDisplayString(DEFAULT_GEMINI_FLASH_LITE_MODEL),
key: DEFAULT_GEMINI_FLASH_LITE_MODEL, key: DEFAULT_GEMINI_FLASH_LITE_MODEL,
}, },
]; ];
@@ -145,12 +145,12 @@ export function ModelDialog({ onClose }: ModelDialogProps): React.JSX.Element {
list.unshift( list.unshift(
{ {
value: previewProValue, value: previewProValue,
title: previewProModel, title: getDisplayString(previewProModel),
key: previewProModel, key: previewProModel,
}, },
{ {
value: PREVIEW_GEMINI_FLASH_MODEL, value: PREVIEW_GEMINI_FLASH_MODEL,
title: PREVIEW_GEMINI_FLASH_MODEL, title: getDisplayString(PREVIEW_GEMINI_FLASH_MODEL),
key: PREVIEW_GEMINI_FLASH_MODEL, key: PREVIEW_GEMINI_FLASH_MODEL,
}, },
); );