Fix modifyOtherKeys enablement on unsupported terminals (#16714)

Co-authored-by: Tommaso Sciortino <sciortino@gmail.com>
This commit is contained in:
seeksky
2026-01-24 01:34:52 +08:00
committed by GitHub
parent 4fc3ebb930
commit b5cac836c5
2 changed files with 4 additions and 14 deletions
@@ -277,7 +277,7 @@ describe('TerminalCapabilityManager', () => {
expect(enableModifyOtherKeys).toHaveBeenCalled();
});
it('should infer modifyOtherKeys support from Device Attributes (DA1) alone', async () => {
it('should not enable modifyOtherKeys without explicit response', async () => {
const manager = TerminalCapabilityManager.getInstance();
const promise = manager.detectCapabilities();
@@ -287,9 +287,7 @@ describe('TerminalCapabilityManager', () => {
await promise;
expect(manager.isKittyProtocolEnabled()).toBe(false);
// It should fall back to modifyOtherKeys because DA1 proves it's an ANSI terminal
expect(enableModifyOtherKeys).toHaveBeenCalled();
expect(enableModifyOtherKeys).not.toHaveBeenCalled();
});
});
});