MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-12 12:54:07 -07:00
Code Issues Packages Projects Releases Wiki Activity

do not toggle the setting item when entering space (#14489)

Browse Source
This commit is contained in:
Sehoon Shon
2025-12-04 09:48:18 -05:00
committed by GitHub
parent 46bb07e4b7
commit b745d46395
2 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/ui/components/SettingsDialog.test.tsx
-14
View File
@@ -466,20 +466,6 @@ describe('SettingsDialog', () => {
}); });
}); });
it('should toggle setting with Space key', async () => {
const settings = createMockSettings();
const onSelect = vi.fn();
const { stdin, unmount } = renderDialog(settings, onSelect);
// Press Space to toggle current setting
act(() => {
stdin.write(' '); // Space key
});
unmount();
});
it('should handle vim mode setting specially', async () => { it('should handle vim mode setting specially', async () => {
const settings = createMockSettings(); const settings = createMockSettings();
const onSelect = vi.fn(); const onSelect = vi.fn();
packages/cli/src/ui/components/SettingsDialog.tsx
+1 -1
View File
@@ -714,7 +714,7 @@ export function SettingsDialog({
} else if (newIndex >= scrollOffset + effectiveMaxItemsToShow) { } else if (newIndex >= scrollOffset + effectiveMaxItemsToShow) {
setScrollOffset(newIndex - effectiveMaxItemsToShow + 1); setScrollOffset(newIndex - effectiveMaxItemsToShow + 1);
} }
} else if (keyMatchers[Command.RETURN](key) || name === 'space') { } else if (keyMatchers[Command.RETURN](key)) {
const currentItem = items[activeSettingIndex]; const currentItem = items[activeSettingIndex];
if ( if (
currentItem?.type === 'number' || currentItem?.type === 'number' ||