MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-07-17 05:20:23 -07:00
Code Issues Packages Projects Releases Wiki Activity

feat(core): add HTTP 499 to retryable errors and map to RetryableQuotaError (#20432)

Browse Source
This commit is contained in:
Bryan Morgan
2026-02-26 10:42:34 -05:00
committed by GitHub
parent 94c2ecef9c
commit bc21652878
8 changed files with 92 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/utils/googleQuotaErrors.test.ts
+17 -1
View File
@@ -81,7 +81,7 @@ describe('classifyGoogleError', () => {
}
});
it('should return original error if code is not 429 or 503', () => {
it('should return original error if code is not 429, 499 or 503', () => {
const apiError: GoogleApiError = {
code: 500,
message: 'Server error',
@@ -95,6 +95,22 @@ describe('classifyGoogleError', () => {
expect(result).not.toBeInstanceOf(RetryableQuotaError);
});
it('should return RetryableQuotaError for 499 Client Closed Request', () => {
const apiError: GoogleApiError = {
code: 499,
message: 'Client Closed Request',
details: [],
};
vi.spyOn(errorParser, 'parseGoogleApiError').mockReturnValue(apiError);
const originalError = new Error('Client Closed Request');
const result = classifyGoogleError(originalError);
expect(result).toBeInstanceOf(RetryableQuotaError);
if (result instanceof RetryableQuotaError) {
expect(result.cause).toBe(apiError);
expect(result.message).toBe('Client Closed Request');
}
});
it('should return TerminalQuotaError for daily quota violations in QuotaFailure', () => {
const apiError: GoogleApiError = {
code: 429,