From bcfe615fedf5725fa0747da3eeebd70a02f93bbc Mon Sep 17 00:00:00 2001
From: "A.K.M. Adib" <adibakm@google.com>
Date: Wed, 11 Mar 2026 11:47:41 -0400
Subject: [PATCH] remove approvalmodechanged event

---
 packages/core/src/config/config.test.ts |  1 -
 packages/core/src/config/config.ts      |  2 --
 packages/core/src/utils/events.ts       | 21 ---------------------
 3 files changed, 24 deletions(-)

diff --git a/packages/core/src/config/config.test.ts b/packages/core/src/config/config.test.ts
index 3c58ce7e77..82d145c4b1 100644
--- a/packages/core/src/config/config.test.ts
+++ b/packages/core/src/config/config.test.ts
@@ -197,7 +197,6 @@ const mockCoreEvents = vi.hoisted(() => ({
   emitModelChanged: vi.fn(),
   emitConsoleLog: vi.fn(),
   emitQuotaChanged: vi.fn(),
-  emitApprovalModeChanged: vi.fn(),
   on: vi.fn(),
 }));
 
diff --git a/packages/core/src/config/config.ts b/packages/core/src/config/config.ts
index 96bb2dc56d..aa5bfca45b 100644
--- a/packages/core/src/config/config.ts
+++ b/packages/core/src/config/config.ts
@@ -2096,8 +2096,6 @@ export class Config implements McpContext, AgentLoopContext {
         : 0;
     }
 
-    coreEvents.emitApprovalModeChanged(mode);
-
     const isPlanModeTransition =
       currentMode !== mode &&
       (currentMode === ApprovalMode.PLAN || mode === ApprovalMode.PLAN);
diff --git a/packages/core/src/utils/events.ts b/packages/core/src/utils/events.ts
index ff1adcd87d..47c42c93ba 100644
--- a/packages/core/src/utils/events.ts
+++ b/packages/core/src/utils/events.ts
@@ -9,7 +9,6 @@ import type { AgentDefinition } from '../agents/types.js';
 import type { McpClient } from '../tools/mcp-client.js';
 import type { ExtensionEvents } from './extensionLoader.js';
 import type { EditorType } from './editor.js';
-import type { ApprovalMode } from '../policy/types.js';
 import type {
   TokenStorageInitializationEvent,
   KeychainAvailabilityEvent,
@@ -53,16 +52,6 @@ export interface ModelChangedPayload {
   model: string;
 }
 
-/**
- * Payload for the 'approval-mode-changed' event.
- */
-export interface ApprovalModeChangedPayload {
-  /**
-   * The new approval mode that was set.
-   */
-  mode: ApprovalMode;
-}
-
 /**
  * Payload for the 'console-log' event.
  */
@@ -182,7 +171,6 @@ export interface QuotaChangedPayload {
 export enum CoreEvent {
   UserFeedback = 'user-feedback',
   ModelChanged = 'model-changed',
-  ApprovalModeChanged = 'approval-mode-changed',
   ConsoleLog = 'console-log',
   Output = 'output',
   MemoryChanged = 'memory-changed',
@@ -216,7 +204,6 @@ export interface EditorSelectedPayload {
 export interface CoreEvents extends ExtensionEvents {
   [CoreEvent.UserFeedback]: [UserFeedbackPayload];
   [CoreEvent.ModelChanged]: [ModelChangedPayload];
-  [CoreEvent.ApprovalModeChanged]: [ApprovalModeChangedPayload];
   [CoreEvent.ConsoleLog]: [ConsoleLogPayload];
   [CoreEvent.Output]: [OutputPayload];
   [CoreEvent.MemoryChanged]: [MemoryChangedPayload];
@@ -328,14 +315,6 @@ export class CoreEventEmitter extends EventEmitter<CoreEvents> {
     this.emit(CoreEvent.ModelChanged, payload);
   }
 
-  /**
-   * Notifies subscribers that the approval mode has changed.
-   */
-  emitApprovalModeChanged(mode: ApprovalMode): void {
-    const payload: ApprovalModeChangedPayload = { mode };
-    this.emit(CoreEvent.ApprovalModeChanged, payload);
-  }
-
   /**
    * Notifies subscribers that settings have been modified.
    */