From bd523c8d4804373a1f3ca2a37440acb1d5aeda59 Mon Sep 17 00:00:00 2001 From: mkorwel Date: Thu, 19 Mar 2026 08:38:20 -0700 Subject: [PATCH] docs: finalize milestone 2 in implementation plans --- plans/milestone-2-cli-management.md | 21 ++++++++++----------- plans/workspaces-implementation.md | 7 +++---- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/plans/milestone-2-cli-management.md b/plans/milestone-2-cli-management.md index 3a81c96746..46f6e39894 100644 --- a/plans/milestone-2-cli-management.md +++ b/plans/milestone-2-cli-management.md @@ -27,27 +27,26 @@ Add the base `workspace` command and its sub-commands to the CLI. Allow the CLI to know where the Workspace Hub is located. -- [ ] Add `workspaces` configuration section to `packages/core/src/config/`. -- [ ] Support multiple Hub profiles in `settings.json`. +- [x] Add `workspaces` configuration section to `packages/core/src/config/`. +- [x] Support multiple Hub profiles in `settings.json`. ### Task 2.3: Basic Hub Client & Auth Implement the communication layer between the CLI and the Hub. -- [ ] Create `packages/core/src/services/workspaceHubClient.ts`. -- [ ] Implement Google OAuth/IAP token injection for API requests. -- [ ] Handle API errors and provide user-friendly feedback in the CLI. +- [x] Create `packages/core/src/services/workspaceHubClient.ts`. +- [x] Implement Google OAuth/IAP token injection for API requests. +- [x] Handle API errors and provide user-friendly feedback in the CLI. ## 3. Verification & Success Criteria -- **List:** `gemini workspace list` shows workspaces currently tracked in - Firestore. -- **Create:** `gemini workspace create my-task` returns a success message and - the new workspace ID. -- **Delete:** `gemini workspace delete [ID]` removes the entry from the list. +- **List:** `gemini wsr list` shows workspaces currently tracked in Firestore. +- **Create:** `gemini wsr create my-task` returns a success message and the new + workspace ID. +- **Delete:** `gemini wsr delete [ID]` removes the entry from the list. - **Auth:** Commands fail with a clear message if the user is not authenticated or the Hub is unreachable. ## 4. Next Steps -- Implement Task 2.1: Add the `workspace` command group to the CLI. +- Milestone 3: Connectivity & Persistence. diff --git a/plans/workspaces-implementation.md b/plans/workspaces-implementation.md index dc0739a558..07c90ab18b 100644 --- a/plans/workspaces-implementation.md +++ b/plans/workspaces-implementation.md @@ -20,10 +20,9 @@ Build the foundational container environment and the core management API. Enable developers to manage their remote fleet from the local CLI. See [Milestone 2 Sub-plan](./milestone-2-cli-management.md) for details. -- [ ] Add `gemini workspace create/list/delete` commands. - -- [ ] Implement Hub authentication (Google OAuth/IAP). -- [ ] Add local configuration for Hub discovery (`settings.json`). +- [x] Add `gemini workspace create/list/delete` commands. +- [x] Implement Hub authentication (Google OAuth/IAP). +- [x] Add local configuration for Hub discovery (`settings.json`). ### Milestone 3: Connectivity & Persistence (Phase 3)