MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-21 19:40:40 -07:00
Code Issues Packages Projects Releases Wiki Activity

Update user extension enablement logic

Browse Source
This commit is contained in:
Christine Betts
2026-01-27 17:14:18 -05:00
parent b07953fb38
commit c0111d3a90
2 changed files with 44 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/cli/src/config/extension-manager.ts
View File

@@ -850,7 +850,7 @@ Would you like to attempt to install via "git clone" instead?`,
if (scope !== SettingScope.Session) {
const scopePath =
scope === SettingScope.Workspace ? this.workspaceDir : homedir();
scope === SettingScope.Workspace ? this.workspaceDir : '/';
this.extensionEnablementManager.disable(name, true, scopePath);
}
await logExtensionDisable(
@@ -885,7 +885,7 @@ Would you like to attempt to install via "git clone" instead?`,
if (scope !== SettingScope.Session) {
const scopePath =
scope === SettingScope.Workspace ? this.workspaceDir : homedir();
scope === SettingScope.Workspace ? this.workspaceDir : '/';
this.extensionEnablementManager.enable(name, true, scopePath);
}
await logExtensionEnable(

42
packages/cli/src/config/extension.test.ts
View File

@@ -2032,6 +2032,25 @@ ${INSTALL_WARNING_MESSAGE}`,
SettingScope.Workspace,
);
});
it('should disable an extension globally at the user scope', async () => {
createExtension({
extensionsDir: userExtensionsDir,
name: 'ext1',
version: '1.0.0',
});
await extensionManager.loadExtensions();
await extensionManager.disableExtension('ext1', SettingScope.User);
// Should be disabled in home dir
expect(
isEnabled({ name: 'ext1', enabledForPath: userExtensionsDir }),
).toBe(false);
// Should be disabled in some other random path (global)
expect(isEnabled({ name: 'ext1', enabledForPath: '/tmp/other' })).toBe(
false,
);
});
});
describe('enableExtension', () => {
@@ -2100,6 +2119,29 @@ ${INSTALL_WARNING_MESSAGE}`,
SettingScope.Workspace,
);
});
it('should enable an extension globally at the user scope', async () => {
createExtension({
extensionsDir: userExtensionsDir,
name: 'ext1',
version: '1.0.0',
});
await extensionManager.loadExtensions();
await extensionManager.disableExtension('ext1', SettingScope.User);
expect(isEnabled({ name: 'ext1', enabledForPath: '/tmp/other' })).toBe(
false,
);
await extensionManager.enableExtension('ext1', SettingScope.User);
expect(isEnabled({ name: 'ext1', enabledForPath: '/tmp/other' })).toBe(
true,
);
expect(
isEnabled({ name: 'ext1', enabledForPath: userExtensionsDir }),
).toBe(true);
});
});
});