refactor: refactor slash command parsing to a util function. (#8381)

2026-05-13 05:12:55 -07:00 · 2025-09-15 23:56:07 +00:00
parent bee5b638dd
commit c0794215d3
3 changed files with 217 additions and 41 deletions
@@ -0,0 +1,140 @@
+/**
+ * @license
+ * Copyright 2025 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import { describe, it, expect } from 'vitest';
+import { parseSlashCommand } from './commands.js';
+import { CommandKind, type SlashCommand } from '../ui/commands/types.js';
+
+// Mock command structure for testing
+const mockCommands: readonly SlashCommand[] = [
+  {
+    name: 'help',
+    description: 'Show help',
+    action: async () => {},
+    kind: CommandKind.BUILT_IN,
+  },
+  {
+    name: 'commit',
+    description: 'Commit changes',
+    action: async () => {},
+    kind: CommandKind.FILE,
+  },
+  {
+    name: 'memory',
+    description: 'Manage memory',
+    altNames: ['mem'],
+    subCommands: [
+      {
+        name: 'add',
+        description: 'Add to memory',
+        action: async () => {},
+        kind: CommandKind.BUILT_IN,
+      },
+      {
+        name: 'clear',
+        description: 'Clear memory',
+        altNames: ['c'],
+        action: async () => {},
+        kind: CommandKind.BUILT_IN,
+      },
+    ],
+    kind: CommandKind.BUILT_IN,
+  },
+];
+
+describe('parseSlashCommand', () => {
+  it('should parse a simple command without arguments', () => {
+    const result = parseSlashCommand('/help', mockCommands);
+    expect(result.commandToExecute?.name).toBe('help');
+    expect(result.args).toBe('');
+    expect(result.canonicalPath).toEqual(['help']);
+  });
+
+  it('should parse a simple command with arguments', () => {
+    const result = parseSlashCommand(
+      '/commit -m "Initial commit"',
+      mockCommands,
+    );
+    expect(result.commandToExecute?.name).toBe('commit');
+    expect(result.args).toBe('-m "Initial commit"');
+    expect(result.canonicalPath).toEqual(['commit']);
+  });
+
+  it('should parse a subcommand', () => {
+    const result = parseSlashCommand('/memory add', mockCommands);
+    expect(result.commandToExecute?.name).toBe('add');
+    expect(result.args).toBe('');
+    expect(result.canonicalPath).toEqual(['memory', 'add']);
+  });
+
+  it('should parse a subcommand with arguments', () => {
+    const result = parseSlashCommand(
+      '/memory add some important data',
+      mockCommands,
+    );
+    expect(result.commandToExecute?.name).toBe('add');
+    expect(result.args).toBe('some important data');
+    expect(result.canonicalPath).toEqual(['memory', 'add']);
+  });
+
+  it('should handle a command alias', () => {
+    const result = parseSlashCommand('/mem add some data', mockCommands);
+    expect(result.commandToExecute?.name).toBe('add');
+    expect(result.args).toBe('some data');
+    expect(result.canonicalPath).toEqual(['memory', 'add']);
+  });
+
+  it('should handle a subcommand alias', () => {
+    const result = parseSlashCommand('/memory c', mockCommands);
+    expect(result.commandToExecute?.name).toBe('clear');
+    expect(result.args).toBe('');
+    expect(result.canonicalPath).toEqual(['memory', 'clear']);
+  });
+
+  it('should return undefined for an unknown command', () => {
+    const result = parseSlashCommand('/unknown', mockCommands);
+    expect(result.commandToExecute).toBeUndefined();
+    expect(result.args).toBe('unknown');
+    expect(result.canonicalPath).toEqual([]);
+  });
+
+  it('should return the parent command if subcommand is unknown', () => {
+    const result = parseSlashCommand(
+      '/memory unknownsub some args',
+      mockCommands,
+    );
+    expect(result.commandToExecute?.name).toBe('memory');
+    expect(result.args).toBe('unknownsub some args');
+    expect(result.canonicalPath).toEqual(['memory']);
+  });
+
+  it('should handle extra whitespace', () => {
+    const result = parseSlashCommand(
+      '  /memory   add  some data  ',
+      mockCommands,
+    );
+    expect(result.commandToExecute?.name).toBe('add');
+    expect(result.args).toBe('some data');
+    expect(result.canonicalPath).toEqual(['memory', 'add']);
+  });
+
+  it('should return undefined if query does not start with a slash', () => {
+    const result = parseSlashCommand('help', mockCommands);
+    expect(result.commandToExecute).toBeUndefined();
+  });
+
+  it('should handle an empty query', () => {
+    const result = parseSlashCommand('', mockCommands);
+    expect(result.commandToExecute).toBeUndefined();
+  });
+
+  it('should handle a query with only a slash', () => {
+    const result = parseSlashCommand('/', mockCommands);
+    expect(result.commandToExecute).toBeUndefined();
+    expect(result.args).toBe('');
+    expect(result.canonicalPath).toEqual([]);
+  });
+});