MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-12 21:03:05 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): disable detached mode in Bun to prevent immediate SIGHUP of child processes (#22620)

Browse Source
This commit is contained in:
euxaristia
2026-04-21 16:01:28 -04:00
committed by GitHub
parent 8999a885f0
commit c47233a474
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/services/shellExecutionService.ts
+7 -1
View File
@@ -531,12 +531,18 @@ export class ShellExecutionService {
cwd: finalCwd, cwd: finalCwd,
} = prepared; } = prepared;
// Bun's child_process does not properly call setsid() for detached
// processes, leaving children in the parent's session without a
// controlling terminal. They receive SIGHUP immediately. Disable
// detached mode in Bun; killProcessGroup already falls back to
// direct-pid kill when the group kill fails.
const isBun = 'bun' in process.versions;
const child = cpSpawn(finalExecutable, finalArgs, { const child = cpSpawn(finalExecutable, finalArgs, {
cwd: finalCwd, cwd: finalCwd,
stdio: ['ignore', 'pipe', 'pipe'], stdio: ['ignore', 'pipe', 'pipe'],
windowsVerbatimArguments: isWindows ? false : undefined, windowsVerbatimArguments: isWindows ? false : undefined,
shell: false, shell: false,
detached: !isWindows, detached: !isWindows && !isBun,
env: finalEnv, env: finalEnv,
}); });