refactor(config): remove enablePromptCompletion from settings (#19974)

This commit is contained in:
Sehoon Shon
2026-02-22 19:10:20 -05:00
committed by GitHub
parent a91bc60e18
commit c537fd5aec
13 changed files with 40 additions and 86 deletions

View File

@@ -94,7 +94,6 @@ const setupMocks = ({
describe('useCommandCompletion', () => {
const mockCommandContext = {} as CommandContext;
const mockConfig = {
getEnablePromptCompletion: () => false,
getGeminiClient: vi.fn(),
} as unknown as Config;
const testRootDir = '/';
@@ -499,7 +498,6 @@ describe('useCommandCompletion', () => {
describe('prompt completion filtering', () => {
it('should not trigger prompt completion for line comments', async () => {
const mockConfig = {
getEnablePromptCompletion: () => true,
getGeminiClient: vi.fn(),
} as unknown as Config;
@@ -532,7 +530,6 @@ describe('useCommandCompletion', () => {
it('should not trigger prompt completion for block comments', async () => {
const mockConfig = {
getEnablePromptCompletion: () => true,
getGeminiClient: vi.fn(),
} as unknown as Config;
@@ -567,7 +564,6 @@ describe('useCommandCompletion', () => {
it('should trigger prompt completion for regular text when enabled', async () => {
const mockConfig = {
getEnablePromptCompletion: () => true,
getGeminiClient: vi.fn(),
} as unknown as Config;

View File

@@ -156,9 +156,7 @@ export function useCommandCompletion({
// Check for prompt completion - only if enabled
const trimmedText = buffer.text.trim();
const isPromptCompletionEnabled =
config?.getEnablePromptCompletion() ?? false;
const isPromptCompletionEnabled = false;
if (
isPromptCompletionEnabled &&
trimmedText.length >= PROMPT_COMPLETION_MIN_LENGTH &&
@@ -179,7 +177,7 @@ export function useCommandCompletion({
completionStart: -1,
completionEnd: -1,
};
}, [cursorRow, cursorCol, buffer.lines, buffer.text, config]);
}, [cursorRow, cursorCol, buffer.lines, buffer.text]);
useAtCompletion({
enabled: active && completionMode === CompletionMode.AT,
@@ -204,7 +202,6 @@ export function useCommandCompletion({
const promptCompletion = usePromptCompletion({
buffer,
config,
enabled: active && completionMode === CompletionMode.PROMPT,
});
useEffect(() => {

View File

@@ -26,13 +26,11 @@ export interface PromptCompletion {
export interface UsePromptCompletionOptions {
buffer: TextBuffer;
config?: Config;
enabled: boolean;
}
export function usePromptCompletion({
buffer,
config,
enabled,
}: UsePromptCompletionOptions): PromptCompletion {
const [ghostText, setGhostText] = useState<string>('');
const [isLoadingGhostText, setIsLoadingGhostText] = useState<boolean>(false);
@@ -42,8 +40,7 @@ export function usePromptCompletion({
const lastSelectedTextRef = useRef<string>('');
const lastRequestedTextRef = useRef<string>('');
const isPromptCompletionEnabled =
enabled && (config?.getEnablePromptCompletion() ?? false);
const isPromptCompletionEnabled = false;
const clearGhostText = useCallback(() => {
setGhostText('');