From c60d8ef5a861685f6f20a4e776aaaefdc1879b63 Mon Sep 17 00:00:00 2001 From: shishu314 Date: Wed, 29 Oct 2025 14:56:09 -0400 Subject: [PATCH] fix(infra) - Unskip read many file test (#12181) Co-authored-by: gemini-cli-robot --- docs/integration-tests.md | 3 +++ integration-tests/read_many_files.test.ts | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/integration-tests.md b/docs/integration-tests.md index 341c8e2899..96bfd2ced3 100644 --- a/docs/integration-tests.md +++ b/docs/integration-tests.md @@ -72,6 +72,9 @@ these responses. REGENERATE_MODEL_GOLDENS="true" npm run test:e2e ``` +**WARNING**: Make sure you run **await rig.cleanup()** at the end of your test, +else the golden files will not be updated. + ### Deflaking a test Before adding a **new** integration test, you should test it at least 5 times diff --git a/integration-tests/read_many_files.test.ts b/integration-tests/read_many_files.test.ts index 3967324392..7a78589bdc 100644 --- a/integration-tests/read_many_files.test.ts +++ b/integration-tests/read_many_files.test.ts @@ -8,7 +8,7 @@ import { describe, it, expect } from 'vitest'; import { TestRig, printDebugInfo, validateModelOutput } from './test-helper.js'; describe('read_many_files', () => { - it.skip('should be able to read multiple files', async () => { + it('should be able to read multiple files', async () => { const rig = new TestRig(); await rig.setup('should be able to read multiple files'); rig.createFile('file1.txt', 'file 1 content'); @@ -43,5 +43,6 @@ describe('read_many_files', () => { // Validate model output - will throw if no output validateModelOutput(result, null, 'Read many files test'); + await rig.cleanup(); }); });