mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-06-24 18:27:01 -07:00
fix: address PR #19284 review comments
- Remove redundant Promise.race in McpToolInvocation.execute (event listener leak) - Propagate AbortSignal to all press_key calls (submitKey + typeCharByChar) - Call this.close() on connectMcp failure (zombie process leak) - Set showInDialog: false for all browser settings - Remove debug log truncation in analyzeScreenshot - Fix misleading --experimental-vision error message - Replace any casts with typed TestableConfirmation interface in tests - Update license year to 2026 in all browser agent files - Merge duplicate imports in mcpToolWrapper - Add sync comment to BrowserAgentCustomConfig - Update subagents.md Chrome requirement wording - Regenerate settings docs
This commit is contained in:
@@ -981,7 +981,7 @@ const SETTINGS_SCHEMA = {
|
||||
default: 'persistent',
|
||||
description:
|
||||
"Session mode: 'persistent', 'isolated', or 'existing'.",
|
||||
showInDialog: true,
|
||||
showInDialog: false,
|
||||
options: [
|
||||
{ value: 'persistent', label: 'Persistent' },
|
||||
{ value: 'isolated', label: 'Isolated' },
|
||||
@@ -995,7 +995,7 @@ const SETTINGS_SCHEMA = {
|
||||
requiresRestart: true,
|
||||
default: false,
|
||||
description: 'Run browser in headless mode.',
|
||||
showInDialog: true,
|
||||
showInDialog: false,
|
||||
},
|
||||
profilePath: {
|
||||
type: 'string',
|
||||
@@ -1005,7 +1005,7 @@ const SETTINGS_SCHEMA = {
|
||||
default: undefined as string | undefined,
|
||||
description:
|
||||
'Path to browser profile directory for session persistence.',
|
||||
showInDialog: true,
|
||||
showInDialog: false,
|
||||
},
|
||||
visualModel: {
|
||||
type: 'string',
|
||||
@@ -1014,7 +1014,7 @@ const SETTINGS_SCHEMA = {
|
||||
requiresRestart: true,
|
||||
default: undefined as string | undefined,
|
||||
description: 'Model override for the visual agent.',
|
||||
showInDialog: true,
|
||||
showInDialog: false,
|
||||
},
|
||||
},
|
||||
},
|
||||
|
||||
@@ -170,8 +170,7 @@ export function SettingsDialog({
|
||||
updated = setPendingSettingValue(key, value, updated);
|
||||
} else if (
|
||||
(def?.type === 'number' && typeof value === 'number') ||
|
||||
(def?.type === 'string' && typeof value === 'string') ||
|
||||
(def?.type === 'enum' && typeof value === 'string')
|
||||
(def?.type === 'string' && typeof value === 'string')
|
||||
) {
|
||||
updated = setPendingSettingValueAny(key, value, updated);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user