MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-23 20:40:41 -07:00
Code Issues Packages Projects Releases Wiki Activity

rename(telemetry): Update ai_(added|removed)_lines to model_(added|removed)_lines (#7577)

Browse Source 
Co-authored-by: Shnatu <snatu@google.com>
Co-authored-by: Billy Biggs <bbiggs@google.com>
This commit is contained in:
Shardul Natu
2025-09-03 20:54:52 -07:00
committed by GitHub
parent 3885f7b6ae
commit cae4cacd6e
9 changed files with 40 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts
View File

@@ -465,8 +465,8 @@ export class ClearcutLogger {
if (event.metadata) {
const metadataMapping: { [key: string]: EventMetadataKey } = {
ai_added_lines: EventMetadataKey.GEMINI_CLI_AI_ADDED_LINES,
ai_removed_lines: EventMetadataKey.GEMINI_CLI_AI_REMOVED_LINES,
model_added_lines: EventMetadataKey.GEMINI_CLI_AI_ADDED_LINES,
model_removed_lines: EventMetadataKey.GEMINI_CLI_AI_REMOVED_LINES,
user_added_lines: EventMetadataKey.GEMINI_CLI_USER_ADDED_LINES,
user_removed_lines: EventMetadataKey.GEMINI_CLI_USER_REMOVED_LINES,
};

4
packages/core/src/telemetry/types.ts
View File

@@ -163,8 +163,8 @@ export class ToolCallEvent implements BaseTelemetryEvent {
const diffStat = (call.response.resultDisplay as FileDiff).diffStat;
if (diffStat) {
this.metadata = {
ai_added_lines: diffStat.ai_added_lines,
ai_removed_lines: diffStat.ai_removed_lines,
model_added_lines: diffStat.model_added_lines,
model_removed_lines: diffStat.model_removed_lines,
user_added_lines: diffStat.user_added_lines,
user_removed_lines: diffStat.user_removed_lines,
};

8
packages/core/src/telemetry/uiTelemetry.test.ts
View File

@@ -646,8 +646,8 @@ describe('UiTelemetryService', () => {
...structuredClone(new ToolCallEvent(toolCall)),
'event.name': EVENT_TOOL_CALL,
metadata: {
ai_added_lines: 10,
ai_removed_lines: 5,
model_added_lines: 10,
model_removed_lines: 5,
},
} as ToolCallEvent & { 'event.name': typeof EVENT_TOOL_CALL };
@@ -664,8 +664,8 @@ describe('UiTelemetryService', () => {
...structuredClone(new ToolCallEvent(toolCall)),
'event.name': EVENT_TOOL_CALL,
metadata: {
ai_added_lines: null,
ai_removed_lines: undefined,
model_added_lines: null,
model_removed_lines: undefined,
},
} as ToolCallEvent & { 'event.name': typeof EVENT_TOOL_CALL };

8
packages/core/src/telemetry/uiTelemetry.ts
View File

@@ -224,11 +224,11 @@ export class UiTelemetryService extends EventEmitter {
// Aggregate line count data from metadata
if (event.metadata) {
if (event.metadata['ai_added_lines'] !== undefined) {
files.totalLinesAdded += event.metadata['ai_added_lines'];
if (event.metadata['model_added_lines'] !== undefined) {
files.totalLinesAdded += event.metadata['model_added_lines'];
}
if (event.metadata['ai_removed_lines'] !== undefined) {
files.totalLinesRemoved += event.metadata['ai_removed_lines'];
if (event.metadata['model_removed_lines'] !== undefined) {
files.totalLinesRemoved += event.metadata['model_removed_lines'];
}
}
}

36
packages/core/src/tools/diffOptions.test.ts
View File

@@ -16,8 +16,8 @@ describe('getDiffStat', () => {
const userStr = 'line1\nline2\n';
const diffStat = getDiffStat(fileName, oldStr, aiStr, userStr);
expect(diffStat).toEqual({
ai_added_lines: 0,
ai_removed_lines: 0,
model_added_lines: 0,
model_removed_lines: 0,
model_added_chars: 0,
model_removed_chars: 0,
user_added_lines: 0,
@@ -33,8 +33,8 @@ describe('getDiffStat', () => {
const userStr = 'line1\nline2\nline3\n';
const diffStat = getDiffStat(fileName, oldStr, aiStr, userStr);
expect(diffStat).toEqual({
ai_added_lines: 1,
ai_removed_lines: 0,
model_added_lines: 1,
model_removed_lines: 0,
model_added_chars: 5,
model_removed_chars: 0,
user_added_lines: 0,
@@ -50,8 +50,8 @@ describe('getDiffStat', () => {
const userStr = 'line1\nline3\n';
const diffStat = getDiffStat(fileName, oldStr, aiStr, userStr);
expect(diffStat).toEqual({
ai_added_lines: 0,
ai_removed_lines: 1,
model_added_lines: 0,
model_removed_lines: 1,
model_added_chars: 0,
model_removed_chars: 5,
user_added_lines: 0,
@@ -67,8 +67,8 @@ describe('getDiffStat', () => {
const userStr = 'line1\nline_two\nline3\n';
const diffStat = getDiffStat(fileName, oldStr, aiStr, userStr);
expect(diffStat).toEqual({
ai_added_lines: 1,
ai_removed_lines: 1,
model_added_lines: 1,
model_removed_lines: 1,
model_added_chars: 8,
model_removed_chars: 5,
user_added_lines: 0,
@@ -84,8 +84,8 @@ describe('getDiffStat', () => {
const userStr = 'line1\nline2\nline3\nline4\n';
const diffStat = getDiffStat(fileName, oldStr, aiStr, userStr);
expect(diffStat).toEqual({
ai_added_lines: 1,
ai_removed_lines: 0,
model_added_lines: 1,
model_removed_lines: 0,
model_added_chars: 5,
model_removed_chars: 0,
user_added_lines: 1,
@@ -101,8 +101,8 @@ describe('getDiffStat', () => {
const userStr = 'line1\nline2\n';
const diffStat = getDiffStat(fileName, oldStr, aiStr, userStr);
expect(diffStat).toEqual({
ai_added_lines: 1,
ai_removed_lines: 0,
model_added_lines: 1,
model_removed_lines: 0,
model_added_chars: 5,
model_removed_chars: 0,
user_added_lines: 0,
@@ -118,8 +118,8 @@ describe('getDiffStat', () => {
const userStr = 'line1\nline2\nline_three\n';
const diffStat = getDiffStat(fileName, oldStr, aiStr, userStr);
expect(diffStat).toEqual({
ai_added_lines: 1,
ai_removed_lines: 0,
model_added_lines: 1,
model_removed_lines: 0,
model_added_chars: 5,
model_removed_chars: 0,
user_added_lines: 1,
@@ -135,8 +135,8 @@ describe('getDiffStat', () => {
const userStr = 'line_one\nline_two\nline_three\nline4\nline5\n';
const diffStat = getDiffStat(fileName, oldStr, aiStr, userStr);
expect(diffStat).toEqual({
ai_added_lines: 2,
ai_removed_lines: 2,
model_added_lines: 2,
model_removed_lines: 2,
model_added_chars: 18,
model_removed_chars: 10,
user_added_lines: 2,
@@ -152,8 +152,8 @@ describe('getDiffStat', () => {
const userStr = 'hello universe';
const diffStat = getDiffStat(fileName, oldStr, aiStr, userStr);
expect(diffStat).toEqual({
ai_added_lines: 1,
ai_removed_lines: 1,
model_added_lines: 1,
model_removed_lines: 1,
model_added_chars: 14,
model_removed_chars: 11,
user_added_lines: 0,

4
packages/core/src/tools/diffOptions.ts
View File

@@ -61,8 +61,8 @@ export function getDiffStat(
const userStats = getStats(userPatch);
return {
ai_added_lines: modelStats.addedLines,
ai_removed_lines: modelStats.removedLines,
model_added_lines: modelStats.addedLines,
model_removed_lines: modelStats.removedLines,
model_added_chars: modelStats.addedChars,
model_removed_chars: modelStats.removedChars,
user_added_lines: userStats.addedLines,

8
packages/core/src/tools/edit.test.ts
View File

@@ -528,8 +528,8 @@ describe('EditTool', () => {
expect(display.fileDiff).toMatch(/\+new text\n\+new text\n\+new text/);
expect(display.fileName).toBe(testFile);
expect((result.returnDisplay as FileDiff).diffStat).toStrictEqual({
ai_added_lines: 3,
ai_removed_lines: 3,
model_added_lines: 3,
model_removed_lines: 3,
model_added_chars: 24,
model_removed_chars: 24,
user_added_lines: 0,
@@ -593,8 +593,8 @@ describe('EditTool', () => {
/User modified the `new_string` content/,
);
expect((result.returnDisplay as FileDiff).diffStat).toStrictEqual({
ai_added_lines: 1,
ai_removed_lines: 1,
model_added_lines: 1,
model_removed_lines: 1,
model_added_chars: 7,
model_removed_chars: 8,
user_added_lines: 1,

4
packages/core/src/tools/tools.ts
View File

@@ -443,8 +443,8 @@ export interface FileDiff {
}
export interface DiffStat {
ai_added_lines: number;
ai_removed_lines: number;
model_added_lines: number;
model_removed_lines: number;
model_added_chars: number;
model_removed_chars: number;
user_added_lines: number;