feat(cli): change default loadingPhrases to 'off' to hide tips (#24342)

This commit is contained in:
Keith Guerin
2026-04-01 16:04:43 -07:00
committed by GitHub
parent 0d7e778e08
commit cb7f7d6c72
5 changed files with 41 additions and 41 deletions
+2 -2
View File
@@ -48,7 +48,7 @@ they appear in the UI.
### UI ### UI
| UI Label | Setting | Description | Default | | UI Label | Setting | Description | Default |
| ------------------------------------ | -------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------- | | ------------------------------------ | -------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------- |
| Auto Theme Switching | `ui.autoThemeSwitching` | Automatically switch between default light and dark themes based on terminal background color. | `true` | | Auto Theme Switching | `ui.autoThemeSwitching` | Automatically switch between default light and dark themes based on terminal background color. | `true` |
| Terminal Background Polling Interval | `ui.terminalBackgroundPollingInterval` | Interval in seconds to poll the terminal background color. | `60` | | Terminal Background Polling Interval | `ui.terminalBackgroundPollingInterval` | Interval in seconds to poll the terminal background color. | `60` |
| Hide Window Title | `ui.hideWindowTitle` | Hide the window title bar | `false` | | Hide Window Title | `ui.hideWindowTitle` | Hide the window title bar | `false` |
@@ -77,7 +77,7 @@ they appear in the UI.
| Use Background Color | `ui.useBackgroundColor` | Whether to use background colors in the UI. | `true` | | Use Background Color | `ui.useBackgroundColor` | Whether to use background colors in the UI. | `true` |
| Incremental Rendering | `ui.incrementalRendering` | Enable incremental rendering for the UI. This option will reduce flickering but may cause rendering artifacts. Only supported when useAlternateBuffer is enabled. | `true` | | Incremental Rendering | `ui.incrementalRendering` | Enable incremental rendering for the UI. This option will reduce flickering but may cause rendering artifacts. Only supported when useAlternateBuffer is enabled. | `true` |
| Show Spinner | `ui.showSpinner` | Show the spinner during operations. | `true` | | Show Spinner | `ui.showSpinner` | Show the spinner during operations. | `true` |
| Loading Phrases | `ui.loadingPhrases` | What to show while the model is working: tips, witty comments, both, or nothing. | `"tips"` | | Loading Phrases | `ui.loadingPhrases` | What to show while the model is working: tips, witty comments, all, or off. | `"off"` |
| Error Verbosity | `ui.errorVerbosity` | Controls whether recoverable errors are hidden (low) or fully shown (full). | `"low"` | | Error Verbosity | `ui.errorVerbosity` | Controls whether recoverable errors are hidden (low) or fully shown (full). | `"low"` |
| Screen Reader Mode | `ui.accessibility.screenReader` | Render output in plain-text to be more screen reader accessible | `false` | | Screen Reader Mode | `ui.accessibility.screenReader` | Render output in plain-text to be more screen reader accessible | `false` |
+2 -2
View File
@@ -354,8 +354,8 @@ their corresponding top-level category object in your `settings.json` file.
- **`ui.loadingPhrases`** (enum): - **`ui.loadingPhrases`** (enum):
- **Description:** What to show while the model is working: tips, witty - **Description:** What to show while the model is working: tips, witty
comments, both, or nothing. comments, all, or off.
- **Default:** `"tips"` - **Default:** `"off"`
- **Values:** `"tips"`, `"witty"`, `"all"`, `"off"` - **Values:** `"tips"`, `"witty"`, `"all"`, `"off"`
- **`ui.errorVerbosity`** (enum): - **`ui.errorVerbosity`** (enum):
@@ -87,7 +87,7 @@ describe('SettingsSchema', () => {
const definition = getSettingsSchema().ui?.properties?.loadingPhrases; const definition = getSettingsSchema().ui?.properties?.loadingPhrases;
expect(definition).toBeDefined(); expect(definition).toBeDefined();
expect(definition?.type).toBe('enum'); expect(definition?.type).toBe('enum');
expect(definition?.default).toBe('tips'); expect(definition?.default).toBe('off');
expect(definition?.options?.map((o) => o.value)).toEqual([ expect(definition?.options?.map((o) => o.value)).toEqual([
'tips', 'tips',
'witty', 'witty',
+2 -2
View File
@@ -776,9 +776,9 @@ const SETTINGS_SCHEMA = {
label: 'Loading Phrases', label: 'Loading Phrases',
category: 'UI', category: 'UI',
requiresRestart: false, requiresRestart: false,
default: 'tips', default: 'off',
description: description:
'What to show while the model is working: tips, witty comments, both, or nothing.', 'What to show while the model is working: tips, witty comments, all, or off.',
showInDialog: true, showInDialog: true,
options: [ options: [
{ value: 'tips', label: 'Tips' }, { value: 'tips', label: 'Tips' },
+3 -3
View File
@@ -478,9 +478,9 @@
}, },
"loadingPhrases": { "loadingPhrases": {
"title": "Loading Phrases", "title": "Loading Phrases",
"description": "What to show while the model is working: tips, witty comments, both, or nothing.", "description": "What to show while the model is working: tips, witty comments, all, or off.",
"markdownDescription": "What to show while the model is working: tips, witty comments, both, or nothing.\n\n- Category: `UI`\n- Requires restart: `no`\n- Default: `tips`", "markdownDescription": "What to show while the model is working: tips, witty comments, all, or off.\n\n- Category: `UI`\n- Requires restart: `no`\n- Default: `off`",
"default": "tips", "default": "off",
"type": "string", "type": "string",
"enum": ["tips", "witty", "all", "off"] "enum": ["tips", "witty", "all", "off"]
}, },