From cb9cc88478603d1bb8072342316c3212a5df9bf8 Mon Sep 17 00:00:00 2001 From: Mark McLaughlin Date: Fri, 6 Mar 2026 16:09:33 -0800 Subject: [PATCH] refactor(ui): simplify measurement hook in BaseSelectionList --- packages/cli/src/ui/components/shared/BaseSelectionList.tsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/cli/src/ui/components/shared/BaseSelectionList.tsx b/packages/cli/src/ui/components/shared/BaseSelectionList.tsx index 172fd0b076..d55269a9c2 100644 --- a/packages/cli/src/ui/components/shared/BaseSelectionList.tsx +++ b/packages/cli/src/ui/components/shared/BaseSelectionList.tsx @@ -96,11 +96,9 @@ export function BaseSelectionList< // We want to track the "true" offset relative to the viewport. // Since we apply -breakoutAmount as a margin to the SELECTED item, // it should not affect the parent container's x coordinate in a standard layout. - if (x !== horizontalOffset) { - setHorizontalOffset(x); - } + setHorizontalOffset(x); } - }, [terminalWidth, mainAreaWidth, horizontalOffset]); + }, [terminalWidth, mainAreaWidth]); // Handle scrolling for long lists useEffect(() => {