From d012929a28491b7f9ca872d390d87bd3cdf7f754 Mon Sep 17 00:00:00 2001 From: Jacob Richman Date: Sun, 8 Mar 2026 00:36:54 -0800 Subject: [PATCH] Code review comments as a pr (#21209) --- .../cli/src/ui/components/Footer.test.tsx | 37 +- packages/cli/src/ui/components/Footer.tsx | 63 ++- .../ui/components/FooterConfigDialog.test.tsx | 93 ++++- .../src/ui/components/FooterConfigDialog.tsx | 389 +++++++++--------- .../__snapshots__/Footer.test.tsx.snap | 24 +- ...ts-the-active-item-in-the-preview.snap.svg | 159 +++++++ ...s-correctly-with-default-settings.snap.svg | 154 +++++++ .../FooterConfigDialog.test.tsx.snap | 125 +++++- .../components/shared/BaseSelectionList.tsx | 4 +- .../src/ui/hooks/useSelectionList.test.tsx | 63 +++ packages/cli/src/ui/hooks/useSelectionList.ts | 3 +- 11 files changed, 845 insertions(+), 269 deletions(-) create mode 100644 packages/cli/src/ui/components/__snapshots__/FooterConfigDialog--FooterConfigDialog-highlights-the-active-item-in-the-preview.snap.svg create mode 100644 packages/cli/src/ui/components/__snapshots__/FooterConfigDialog--FooterConfigDialog-renders-correctly-with-default-settings.snap.svg diff --git a/packages/cli/src/ui/components/Footer.test.tsx b/packages/cli/src/ui/components/Footer.test.tsx index 667168dbc5..21aa6ee5c0 100644 --- a/packages/cli/src/ui/components/Footer.test.tsx +++ b/packages/cli/src/ui/components/Footer.test.tsx @@ -132,9 +132,7 @@ describe('