Protect stdout and stderr so JavaScript code can't accidentally write to stdout corrupting ink rendering (#13247)

Bypassing rules as link checker failure is spurious.

packages/cli/src/commands/extensions/uninstall.test.ts

@@ -13,6 +13,7 @@ import {
   afterEach,
   type Mock,
 } from 'vitest';
+import { format } from 'node:util';
 import { type CommandModule, type Argv } from 'yargs';
 import { handleUninstall, uninstallCommand } from './uninstall.js';
 import { ExtensionManager } from '../../config/extension-manager.js';
@@ -43,19 +44,31 @@ vi.mock('../../config/extension-manager.js', async (importOriginal) => {
   };
 });
 
-vi.mock('../../config/settings.js');
-vi.mock('../../utils/errors.js');
+// Mock dependencies
+const emitConsoleLog = vi.hoisted(() => vi.fn());
+const debugLogger = vi.hoisted(() => ({
+  log: vi.fn((message, ...args) => {
+    emitConsoleLog('log', format(message, ...args));
+  }),
+  error: vi.fn((message, ...args) => {
+    emitConsoleLog('error', format(message, ...args));
+  }),
+}));
+
 vi.mock('@google/gemini-cli-core', async (importOriginal) => {
   const actual =
     await importOriginal<typeof import('@google/gemini-cli-core')>();
   return {
     ...actual,
-    debugLogger: {
-      log: vi.fn(),
-      error: vi.fn(),
+    coreEvents: {
+      emitConsoleLog,
     },
+    debugLogger,
   };
 });
+
+vi.mock('../../config/settings.js');
+vi.mock('../../utils/errors.js');
 vi.mock('../../config/extensions/consent.js', () => ({
   requestConsentNonInteractive: vi.fn(),
 }));
@@ -67,15 +80,8 @@ describe('extensions uninstall command', () => {
   const mockLoadSettings = vi.mocked(loadSettings);
   const mockGetErrorMessage = vi.mocked(getErrorMessage);
   const mockExtensionManager = vi.mocked(ExtensionManager);
-  interface MockDebugLogger {
-    log: Mock;
-    error: Mock;
-  }
-  let mockDebugLogger: MockDebugLogger;
 
   beforeEach(async () => {
-    mockDebugLogger = (await import('@google/gemini-cli-core'))
-      .debugLogger as unknown as MockDebugLogger;
     mockLoadSettings.mockReturnValue({
       merged: {},
     } as unknown as LoadedSettings);
@@ -104,7 +110,8 @@ describe('extensions uninstall command', () => {
         'my-extension',
         false,
       );
-      expect(mockDebugLogger.log).toHaveBeenCalledWith(
+      expect(emitConsoleLog).toHaveBeenCalledWith(
+        'log',
         'Extension "my-extension" successfully uninstalled.',
       );
       mockCwd.mockRestore();
@@ -120,13 +127,16 @@ describe('extensions uninstall command', () => {
       expect(mockUninstallExtension).toHaveBeenCalledWith('ext1', false);
       expect(mockUninstallExtension).toHaveBeenCalledWith('ext2', false);
       expect(mockUninstallExtension).toHaveBeenCalledWith('ext3', false);
-      expect(mockDebugLogger.log).toHaveBeenCalledWith(
+      expect(emitConsoleLog).toHaveBeenCalledWith(
+        'log',
         'Extension "ext1" successfully uninstalled.',
       );
-      expect(mockDebugLogger.log).toHaveBeenCalledWith(
+      expect(emitConsoleLog).toHaveBeenCalledWith(
+        'log',
         'Extension "ext2" successfully uninstalled.',
       );
-      expect(mockDebugLogger.log).toHaveBeenCalledWith(
+      expect(emitConsoleLog).toHaveBeenCalledWith(
+        'log',
         'Extension "ext3" successfully uninstalled.',
       );
       mockCwd.mockRestore();
@@ -152,13 +162,16 @@ describe('extensions uninstall command', () => {
       await handleUninstall({ names: ['ext1', 'ext2', 'ext3'] });
 
       expect(mockUninstallExtension).toHaveBeenCalledTimes(3);
-      expect(mockDebugLogger.log).toHaveBeenCalledWith(
+      expect(emitConsoleLog).toHaveBeenCalledWith(
+        'log',
         'Extension "ext1" successfully uninstalled.',
       );
-      expect(mockDebugLogger.error).toHaveBeenCalledWith(
+      expect(emitConsoleLog).toHaveBeenCalledWith(
+        'error',
         'Failed to uninstall "ext2": Extension not found',
       );
-      expect(mockDebugLogger.log).toHaveBeenCalledWith(
+      expect(emitConsoleLog).toHaveBeenCalledWith(
+        'log',
         'Extension "ext3" successfully uninstalled.',
       );
       expect(mockProcessExit).toHaveBeenCalledWith(1);
@@ -180,10 +193,12 @@ describe('extensions uninstall command', () => {
 
       await handleUninstall({ names: ['ext1', 'ext2'] });
 
-      expect(mockDebugLogger.error).toHaveBeenCalledWith(
+      expect(emitConsoleLog).toHaveBeenCalledWith(
+        'error',
         'Failed to uninstall "ext1": Extension not found',
       );
-      expect(mockDebugLogger.error).toHaveBeenCalledWith(
+      expect(emitConsoleLog).toHaveBeenCalledWith(
+        'error',
         'Failed to uninstall "ext2": Extension not found',
       );
       expect(mockProcessExit).toHaveBeenCalledWith(1);
@@ -204,7 +219,8 @@ describe('extensions uninstall command', () => {
 
       await handleUninstall({ names: ['my-extension'] });
 
-      expect(mockDebugLogger.error).toHaveBeenCalledWith(
+      expect(emitConsoleLog).toHaveBeenCalledWith(
+        'error',
         'Initialization failed message',
       );
       expect(mockProcessExit).toHaveBeenCalledWith(1);