MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-20 18:14:29 -07:00
Code Issues Packages Projects Releases Wiki Activity

Protect stdout and stderr so JavaScript code can't accidentally write to stdout corrupting ink rendering (#13247)

Browse Source 
Bypassing rules as link checker failure is spurious.
This commit is contained in:
Jacob Richman
2025-11-20 10:44:02 -08:00
committed by GitHub
parent e20d282088
commit d1e35f8660
82 changed files with 1523 additions and 868 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/utils/debugLogger.test.ts
+29 -26
View File
@@ -4,76 +4,79 @@
* SPDX-License-Identifier: Apache-2.0
*/
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import { describe, it, expect, vi, afterEach } from 'vitest';
import { debugLogger } from './debugLogger.js';
describe('DebugLogger', () => {
// Spy on all console methods before each test
beforeEach(() => {
vi.spyOn(console, 'log').mockImplementation(() => {});
vi.spyOn(console, 'warn').mockImplementation(() => {});
vi.spyOn(console, 'error').mockImplementation(() => {});
vi.spyOn(console, 'debug').mockImplementation(() => {});
});
// Restore original console methods after each test
afterEach(() => {
vi.restoreAllMocks();
});
it('should call console.log with the correct arguments', () => {
const spy = vi.spyOn(console, 'log').mockImplementation(() => {});
const message = 'This is a log message';
const data = { key: 'value' };
debugLogger.log(message, data);
expect(console.log).toHaveBeenCalledWith(message, data);
expect(console.log).toHaveBeenCalledTimes(1);
expect(spy).toHaveBeenCalledWith(message, data);
expect(spy).toHaveBeenCalledTimes(1);
});
it('should call console.warn with the correct arguments', () => {
const spy = vi.spyOn(console, 'warn').mockImplementation(() => {});
const message = 'This is a warning message';
const data = [1, 2, 3];
debugLogger.warn(message, data);
expect(console.warn).toHaveBeenCalledWith(message, data);
expect(console.warn).toHaveBeenCalledTimes(1);
expect(spy).toHaveBeenCalledWith(message, data);
expect(spy).toHaveBeenCalledTimes(1);
});
it('should call console.error with the correct arguments', () => {
const spy = vi.spyOn(console, 'error').mockImplementation(() => {});
const message = 'This is an error message';
const error = new Error('Something went wrong');
debugLogger.error(message, error);
expect(console.error).toHaveBeenCalledWith(message, error);
expect(console.error).toHaveBeenCalledTimes(1);
expect(spy).toHaveBeenCalledWith(message, error);
expect(spy).toHaveBeenCalledTimes(1);
});
it('should call console.debug with the correct arguments', () => {
const spy = vi.spyOn(console, 'debug').mockImplementation(() => {});
const message = 'This is a debug message';
const obj = { a: { b: 'c' } };
debugLogger.debug(message, obj);
expect(console.debug).toHaveBeenCalledWith(message, obj);
expect(console.debug).toHaveBeenCalledTimes(1);
expect(spy).toHaveBeenCalledWith(message, obj);
expect(spy).toHaveBeenCalledTimes(1);
});
it('should handle multiple arguments correctly for all methods', () => {
const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
const debugSpy = vi.spyOn(console, 'debug').mockImplementation(() => {});
debugLogger.log('one', 2, true);
expect(console.log).toHaveBeenCalledWith('one', 2, true);
expect(logSpy).toHaveBeenCalledWith('one', 2, true);
debugLogger.warn('one', 2, false);
expect(console.warn).toHaveBeenCalledWith('one', 2, false);
expect(warnSpy).toHaveBeenCalledWith('one', 2, false);
debugLogger.error('one', 2, null);
expect(console.error).toHaveBeenCalledWith('one', 2, null);
expect(errorSpy).toHaveBeenCalledWith('one', 2, null);
debugLogger.debug('one', 2, undefined);
expect(console.debug).toHaveBeenCalledWith('one', 2, undefined);
expect(debugSpy).toHaveBeenCalledWith('one', 2, undefined);
});
it('should handle calls with no arguments', () => {
const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
debugLogger.log();
expect(console.log).toHaveBeenCalledWith();
expect(console.log).toHaveBeenCalledTimes(1);
expect(logSpy).toHaveBeenCalledWith();
expect(logSpy).toHaveBeenCalledTimes(1);
debugLogger.warn();
expect(console.warn).toHaveBeenCalledWith();
expect(console.warn).toHaveBeenCalledTimes(1);
expect(warnSpy).toHaveBeenCalledWith();
expect(warnSpy).toHaveBeenCalledTimes(1);
});
});