MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-21 10:34:35 -07:00
Code Issues Packages Projects Releases Wiki Activity

feat(cli): unify /chat and /resume command UX (#20256)

Browse Source
This commit is contained in:
Dmitry Lyalin
2026-03-08 18:50:51 -04:00
committed by GitHub
parent d012929a28
commit d41735d6a9
18 changed files with 619 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/ui/hooks/useSlashCompletion.test.ts
+130 -2
View File
@@ -438,6 +438,129 @@ describe('useSlashCompletion', () => {
unmount();
});
it('should show the same selectable auto/checkpoint menu for /chat and /resume', async () => {
const checkpointSubCommands = [
createTestCommand({
name: 'list',
description: 'List checkpoints',
suggestionGroup: 'checkpoints',
action: vi.fn(),
}),
createTestCommand({
name: 'save',
description: 'Save checkpoint',
suggestionGroup: 'checkpoints',
action: vi.fn(),
}),
];
const slashCommands = [
createTestCommand({
name: 'chat',
description: 'Chat command',
action: vi.fn(),
subCommands: checkpointSubCommands,
}),
createTestCommand({
name: 'resume',
description: 'Resume command',
action: vi.fn(),
subCommands: checkpointSubCommands,
}),
];
const { result: chatResult, unmount: unmountChat } = renderHook(() =>
useTestHarnessForSlashCompletion(
true,
'/chat',
slashCommands,
mockCommandContext,
),
);
await waitFor(() => {
expect(chatResult.current.suggestions[0]).toMatchObject({
label: 'list',
sectionTitle: 'auto',
submitValue: '/chat',
});
});
const { result: resumeResult, unmount: unmountResume } = renderHook(() =>
useTestHarnessForSlashCompletion(
true,
'/resume',
slashCommands,
mockCommandContext,
),
);
await waitFor(() => {
expect(resumeResult.current.suggestions[0]).toMatchObject({
label: 'list',
sectionTitle: 'auto',
submitValue: '/resume',
});
});
const chatCheckpointLabels = chatResult.current.suggestions
.slice(1)
.map((s) => s.label);
const resumeCheckpointLabels = resumeResult.current.suggestions
.slice(1)
.map((s) => s.label);
expect(chatCheckpointLabels).toEqual(resumeCheckpointLabels);
unmountChat();
unmountResume();
});
it('should show the grouped /resume menu for unique /resum prefix input', async () => {
const slashCommands = [
createTestCommand({
name: 'resume',
description: 'Resume command',
action: vi.fn(),
subCommands: [
createTestCommand({
name: 'list',
description: 'List checkpoints',
suggestionGroup: 'checkpoints',
}),
createTestCommand({
name: 'save',
description: 'Save checkpoint',
suggestionGroup: 'checkpoints',
}),
],
}),
];
const { result, unmount } = renderHook(() =>
useTestHarnessForSlashCompletion(
true,
'/resum',
slashCommands,
mockCommandContext,
),
);
await waitFor(() => {
expect(result.current.suggestions[0]).toMatchObject({
label: 'list',
sectionTitle: 'auto',
submitValue: '/resume',
});
expect(result.current.isPerfectMatch).toBe(false);
expect(result.current.suggestions.slice(1).map((s) => s.label)).toEqual(
expect.arrayContaining(['list', 'save']),
);
});
unmount();
});
it('should sort exact altName matches to the top', async () => {
const slashCommands = [
createTestCommand({
@@ -492,8 +615,13 @@ describe('useSlashCompletion', () => {
);
await waitFor(() => {
// Should show subcommands of 'chat'
expect(result.current.suggestions).toHaveLength(2);
// Should show the auto-session entry plus subcommands of 'chat'
expect(result.current.suggestions).toHaveLength(3);
expect(result.current.suggestions[0]).toMatchObject({
label: 'list',
sectionTitle: 'auto',
submitValue: '/chat',
});
expect(result.current.suggestions.map((s) => s.label)).toEqual(
expect.arrayContaining(['list', 'save']),
);