From d465a26e305865ce3f5a145d216466ecbe44de26 Mon Sep 17 00:00:00 2001 From: Adam Weidman <65992621+adamfweidman@users.noreply.github.com> Date: Tue, 28 Oct 2025 11:26:39 -0400 Subject: [PATCH] chore(console): change console errors in sa-impersontation (#12165) --- .../core/src/mcp/sa-impersonation-provider.ts | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/packages/core/src/mcp/sa-impersonation-provider.ts b/packages/core/src/mcp/sa-impersonation-provider.ts index b9335e2622..2b9516d0d4 100644 --- a/packages/core/src/mcp/sa-impersonation-provider.ts +++ b/packages/core/src/mcp/sa-impersonation-provider.ts @@ -14,9 +14,12 @@ import { GoogleAuth } from 'google-auth-library'; import { OAuthUtils, FIVE_MIN_BUFFER_MS } from './oauth-utils.js'; import type { MCPServerConfig } from '../config/config.js'; import type { OAuthClientProvider } from '@modelcontextprotocol/sdk/client/auth.js'; +import { coreEvents } from '../utils/events.js'; function createIamApiUrl(targetSA: string): string { - return `https://iamcredentials.googleapis.com/v1/projects/-/serviceAccounts/${encodeURIComponent(targetSA)}:generateIdToken`; + return `https://iamcredentials.googleapis.com/v1/projects/-/serviceAccounts/${encodeURIComponent( + targetSA, + )}:generateIdToken`; } export class ServiceAccountImpersonationProvider @@ -103,11 +106,18 @@ export class ServiceAccountImpersonationProvider idToken = res.data.token; if (!idToken || idToken.length === 0) { - console.error('Failed to get ID token from Google'); + coreEvents.emitFeedback( + 'error', + 'Failed to obtain authentication token.', + ); return undefined; } } catch (e) { - console.error('Failed to fetch ID token from Google:', e); + coreEvents.emitFeedback( + 'error', + 'Failed to obtain authentication token.', + e as Error, + ); return undefined; }