Update setting search UX (#14451)

This commit is contained in:
Adib234
2025-12-03 22:43:11 -08:00
committed by GitHub
parent 9bc5a4d64f
commit d5e5f58737
3 changed files with 261 additions and 253 deletions
@@ -3,34 +3,37 @@
exports[`SettingsDialog > Initial Rendering > should render settings list with visual indicators 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ > Settings (press / to search)
> Settings
│ │
● Preview Features (e.g., models) false
╭──────────────────────────────────────────────────────────────────────────────────────────────╮
│ Search to filter
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
Vim Mode false
│ ● Preview Features (e.g., models) false │
│ │
Disable Auto Update false
Vim Mode false │
│ │
Enable Prompt Completion false
Disable Auto Update false │
│ │
Debug Keystroke Logging false
Enable Prompt Completion false │
│ │
Enable Session Cleanup false
Debug Keystroke Logging false │
│ │
Output Format Text
Enable Session Cleanup false
│ │
Hide Window Title false
Output Format Text
│ │
Hide Window Title false
│ │
│ ▼ │
│ │
│ Apply To
│ ● User Settings
│ Workspace Settings
│ System Settings
Apply To │
● User Settings │
Workspace Settings │
System Settings │
│ │
│ (Use Enter to select, Tab to change focus, Esc to close)
(Use Enter to select, Tab to change focus, Esc to close) │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯"
`;
@@ -38,34 +41,37 @@ exports[`SettingsDialog > Initial Rendering > should render settings list with v
exports[`SettingsDialog > Snapshot Tests > should render 'accessibility settings enabled' correctly 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ > Settings (press / to search)
> Settings
│ │
● Preview Features (e.g., models) false
╭──────────────────────────────────────────────────────────────────────────────────────────────╮
│ Search to filter
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
Vim Mode true*
│ ● Preview Features (e.g., models) false │
│ │
Disable Auto Update false
Vim Mode true*
│ │
Enable Prompt Completion false
Disable Auto Update false │
│ │
Debug Keystroke Logging false
Enable Prompt Completion false │
│ │
Enable Session Cleanup false
Debug Keystroke Logging false │
│ │
Output Format Text
Enable Session Cleanup false
│ │
Hide Window Title false
Output Format Text
│ │
Hide Window Title false
│ │
│ ▼ │
│ │
│ Apply To
│ ● User Settings
│ Workspace Settings
│ System Settings
Apply To │
● User Settings │
Workspace Settings │
System Settings │
│ │
│ (Use Enter to select, Tab to change focus, Esc to close)
(Use Enter to select, Tab to change focus, Esc to close) │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯"
`;
@@ -73,34 +79,37 @@ exports[`SettingsDialog > Snapshot Tests > should render 'accessibility settings
exports[`SettingsDialog > Snapshot Tests > should render 'all boolean settings disabled' correctly 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ > Settings (press / to search)
> Settings
│ │
● Preview Features (e.g., models) false
╭──────────────────────────────────────────────────────────────────────────────────────────────╮
│ Search to filter
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
Vim Mode false*
│ ● Preview Features (e.g., models) false │
│ │
Disable Auto Update false*
Vim Mode false* │
│ │
Enable Prompt Completion false*
Disable Auto Update false* │
│ │
Debug Keystroke Logging false*
Enable Prompt Completion false* │
│ │
Enable Session Cleanup false
Debug Keystroke Logging false*
│ │
Output Format Text
Enable Session Cleanup false
│ │
Hide Window Title false*
Output Format Text
│ │
Hide Window Title false*
│ │
│ ▼ │
│ │
│ Apply To
│ ● User Settings
│ Workspace Settings
│ System Settings
Apply To │
● User Settings │
Workspace Settings │
System Settings │
│ │
│ (Use Enter to select, Tab to change focus, Esc to close)
(Use Enter to select, Tab to change focus, Esc to close) │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯"
`;
@@ -108,34 +117,37 @@ exports[`SettingsDialog > Snapshot Tests > should render 'all boolean settings d
exports[`SettingsDialog > Snapshot Tests > should render 'default state' correctly 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ > Settings (press / to search)
> Settings
│ │
● Preview Features (e.g., models) false
╭──────────────────────────────────────────────────────────────────────────────────────────────╮
│ Search to filter
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
Vim Mode false
│ ● Preview Features (e.g., models) false │
│ │
Disable Auto Update false
Vim Mode false │
│ │
Enable Prompt Completion false
Disable Auto Update false │
│ │
Debug Keystroke Logging false
Enable Prompt Completion false │
│ │
Enable Session Cleanup false
Debug Keystroke Logging false │
│ │
Output Format Text
Enable Session Cleanup false
│ │
Hide Window Title false
Output Format Text
│ │
Hide Window Title false
│ │
│ ▼ │
│ │
│ Apply To
│ ● User Settings
│ Workspace Settings
│ System Settings
Apply To │
● User Settings │
Workspace Settings │
System Settings │
│ │
│ (Use Enter to select, Tab to change focus, Esc to close)
(Use Enter to select, Tab to change focus, Esc to close) │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯"
`;
@@ -143,34 +155,37 @@ exports[`SettingsDialog > Snapshot Tests > should render 'default state' correct
exports[`SettingsDialog > Snapshot Tests > should render 'file filtering settings configured' correctly 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ > Settings (press / to search)
> Settings
│ │
● Preview Features (e.g., models) false
╭──────────────────────────────────────────────────────────────────────────────────────────────╮
│ Search to filter
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
Vim Mode false
│ ● Preview Features (e.g., models) false │
│ │
Disable Auto Update false
Vim Mode false │
│ │
Enable Prompt Completion false
Disable Auto Update false │
│ │
Debug Keystroke Logging false
Enable Prompt Completion false │
│ │
Enable Session Cleanup false
Debug Keystroke Logging false │
│ │
Output Format Text
Enable Session Cleanup false
│ │
Hide Window Title false
Output Format Text
│ │
Hide Window Title false
│ │
│ ▼ │
│ │
│ Apply To
│ ● User Settings
│ Workspace Settings
│ System Settings
Apply To │
● User Settings │
Workspace Settings │
System Settings │
│ │
│ (Use Enter to select, Tab to change focus, Esc to close)
(Use Enter to select, Tab to change focus, Esc to close) │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯"
`;
@@ -178,34 +193,37 @@ exports[`SettingsDialog > Snapshot Tests > should render 'file filtering setting
exports[`SettingsDialog > Snapshot Tests > should render 'focused on scope selector' correctly 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ Settings (press / to search)
Settings
│ │
Preview Features (e.g., models) false
╭──────────────────────────────────────────────────────────────────────────────────────────────╮
│ Search to filter
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
Vim Mode false
│ Preview Features (e.g., models) false │
│ │
Disable Auto Update false
Vim Mode false │
│ │
Enable Prompt Completion false
Disable Auto Update false │
│ │
Debug Keystroke Logging false
Enable Prompt Completion false │
│ │
Enable Session Cleanup false
Debug Keystroke Logging false │
│ │
Output Format Text
Enable Session Cleanup false
│ │
Hide Window Title false
Output Format Text
│ │
Hide Window Title false
│ │
│ ▼ │
│ │
│ > Apply To
│ ● 1. User Settings
│ 2. Workspace Settings
│ 3. System Settings
> Apply To │
● 1. User Settings │
2. Workspace Settings │
3. System Settings │
│ │
│ (Use Enter to select, Tab to change focus, Esc to close)
(Use Enter to select, Tab to change focus, Esc to close) │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯"
`;
@@ -213,34 +231,37 @@ exports[`SettingsDialog > Snapshot Tests > should render 'focused on scope selec
exports[`SettingsDialog > Snapshot Tests > should render 'mixed boolean and number settings' correctly 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ > Settings (press / to search)
> Settings
│ │
● Preview Features (e.g., models) false
╭──────────────────────────────────────────────────────────────────────────────────────────────╮
│ Search to filter
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
Vim Mode false*
│ ● Preview Features (e.g., models) false │
│ │
Disable Auto Update true*
Vim Mode false*
│ │
Enable Prompt Completion false
Disable Auto Update true*
│ │
Debug Keystroke Logging false
Enable Prompt Completion false │
│ │
Enable Session Cleanup false
Debug Keystroke Logging false │
│ │
Output Format Text
Enable Session Cleanup false
│ │
Hide Window Title false*
Output Format Text
│ │
Hide Window Title false*
│ │
│ ▼ │
│ │
│ Apply To
│ ● User Settings
│ Workspace Settings
│ System Settings
Apply To │
● User Settings │
Workspace Settings │
System Settings │
│ │
│ (Use Enter to select, Tab to change focus, Esc to close)
(Use Enter to select, Tab to change focus, Esc to close) │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯"
`;
@@ -248,34 +269,37 @@ exports[`SettingsDialog > Snapshot Tests > should render 'mixed boolean and numb
exports[`SettingsDialog > Snapshot Tests > should render 'tools and security settings' correctly 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ > Settings (press / to search)
> Settings
│ │
● Preview Features (e.g., models) false
╭──────────────────────────────────────────────────────────────────────────────────────────────╮
│ Search to filter
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
Vim Mode false
│ ● Preview Features (e.g., models) false │
│ │
Disable Auto Update false
Vim Mode false │
│ │
Enable Prompt Completion false
Disable Auto Update false │
│ │
Debug Keystroke Logging false
Enable Prompt Completion false │
│ │
Enable Session Cleanup false
Debug Keystroke Logging false │
│ │
Output Format Text
Enable Session Cleanup false
│ │
Hide Window Title false
Output Format Text
│ │
Hide Window Title false
│ │
│ ▼ │
│ │
│ Apply To
│ ● User Settings
│ Workspace Settings
│ System Settings
Apply To │
● User Settings │
Workspace Settings │
System Settings │
│ │
│ (Use Enter to select, Tab to change focus, Esc to close)
(Use Enter to select, Tab to change focus, Esc to close) │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯"
`;
@@ -283,34 +307,37 @@ exports[`SettingsDialog > Snapshot Tests > should render 'tools and security set
exports[`SettingsDialog > Snapshot Tests > should render 'various boolean settings enabled' correctly 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ > Settings (press / to search)
> Settings
│ │
● Preview Features (e.g., models) false
╭──────────────────────────────────────────────────────────────────────────────────────────────╮
│ Search to filter
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
Vim Mode true*
│ ● Preview Features (e.g., models) false │
│ │
Disable Auto Update true*
Vim Mode true* │
│ │
Enable Prompt Completion true*
Disable Auto Update true* │
│ │
Debug Keystroke Logging true*
Enable Prompt Completion true* │
│ │
Enable Session Cleanup false
Debug Keystroke Logging true*
│ │
Output Format Text
Enable Session Cleanup false
│ │
Hide Window Title true*
Output Format Text
│ │
Hide Window Title true*
│ │
│ ▼ │
│ │
│ Apply To
│ ● User Settings
│ Workspace Settings
│ System Settings
Apply To │
● User Settings │
Workspace Settings │
System Settings │
│ │
│ (Use Enter to select, Tab to change focus, Esc to close)
(Use Enter to select, Tab to change focus, Esc to close) │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯"
`;