From d6492830b6d0560681ff5dcb86a01e60f35318bd Mon Sep 17 00:00:00 2001
From: ehedlund <ehedlund@google.com>
Date: Wed, 15 Apr 2026 17:18:17 -0400
Subject: [PATCH] address GitHub security feedback

---
 .../core/src/sandbox/windows/WindowsSandboxManager.ts     | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/packages/core/src/sandbox/windows/WindowsSandboxManager.ts b/packages/core/src/sandbox/windows/WindowsSandboxManager.ts
index 2ca0636ace..1367d43b92 100644
--- a/packages/core/src/sandbox/windows/WindowsSandboxManager.ts
+++ b/packages/core/src/sandbox/windows/WindowsSandboxManager.ts
@@ -446,7 +446,13 @@ export function isSecretFile(fileName: string): boolean {
   return SECRET_FILES.some((s) => {
     if (s.pattern.includes('*')) {
       const regex = new RegExp(
-        '^' + s.pattern.replace(/\./g, '\\.').replace(/\*/g, '.*') + '$',
+        '^' +
+          s.pattern
+            // Escape all regex special chars
+            .replace(/[.*+?^${}()|[\]\\]/g, '\\$&')
+            // Convert the escaped asterisk back to a regex wildcard
+            .replace(/\\\*/g, '.*') +
+          '$',
       );
       return regex.test(fileName);
     }