From d8e9db37611920a12e95f6ef77b38203672d53b5 Mon Sep 17 00:00:00 2001 From: "A.K.M. Adib" Date: Mon, 26 Jan 2026 20:24:45 -0500 Subject: [PATCH] address feedback --- packages/core/src/utils/package.test.ts | 6 +++--- packages/core/src/utils/package.ts | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/core/src/utils/package.test.ts b/packages/core/src/utils/package.test.ts index f330b2c7da..4dd48065b5 100644 --- a/packages/core/src/utils/package.test.ts +++ b/packages/core/src/utils/package.test.ts @@ -22,14 +22,14 @@ describe('getPackageJson', () => { }); it('should return packageJson when found', async () => { - const mockPackageJson = { name: 'test-pkg', version: '1.2.3' }; + const expectedPackageJsonResult = { name: 'test-pkg', version: '1.2.3' }; vi.mocked(readPackageUp).mockResolvedValue({ - packageJson: mockPackageJson, + packageJson: expectedPackageJsonResult, path: '/path/to/package.json', }); const result = await getPackageJson('/some/path'); - expect(result).toEqual(mockPackageJson); + expect(result).toEqual(expectedPackageJsonResult); expect(readPackageUp).toHaveBeenCalledWith({ cwd: '/some/path', normalize: false, diff --git a/packages/core/src/utils/package.ts b/packages/core/src/utils/package.ts index 68c0d94397..b203e42062 100644 --- a/packages/core/src/utils/package.ts +++ b/packages/core/src/utils/package.ts @@ -8,6 +8,7 @@ import { readPackageUp, type PackageJson as BasePackageJson, } from 'read-package-up'; +import { debugLogger } from './debugLogger.js'; export type PackageJson = BasePackageJson & { config?: { @@ -39,7 +40,8 @@ export async function getPackageJson( } return result.packageJson; - } catch (_error) { + } catch (error) { + debugLogger.error('Error occurred while reading package.json', error); return undefined; } }