MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-21 03:21:11 -07:00
Code Issues Packages Projects Releases Wiki Activity

refactor: rename formatMemoryUsage to formatBytes (#14997)

Browse Source 
Co-authored-by: Adib234 <30782825+Adib234@users.noreply.github.com>
This commit is contained in:
Mark Cockram
2026-01-27 17:21:53 +01:00
committed by GitHub
parent 362384112e
commit db028bc19a
9 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/src/tools/shell.ts
View File

@@ -32,7 +32,7 @@ import type {
ShellOutputEvent,
} from '../services/shellExecutionService.js';
import { ShellExecutionService } from '../services/shellExecutionService.js';
import { formatMemoryUsage } from '../utils/formatters.js';
import { formatBytes } from '../utils/formatters.js';
import type { AnsiOutput } from '../utils/terminalSerializer.js';
import {
getCommandRoots,
@@ -231,7 +231,7 @@ export class ShellToolInvocation extends BaseToolInvocation<
break;
case 'binary_progress':
isBinaryStream = true;
cumulativeOutput = `[Receiving binary output... ${formatMemoryUsage(
cumulativeOutput = `[Receiving binary output... ${formatBytes(
event.bytesReceived,
)} received]`;
if (Date.now() - lastUpdateTime > OUTPUT_UPDATE_INTERVAL_MS) {

10
packages/core/src/utils/formatters.test.ts
View File

@@ -6,7 +6,7 @@
import { describe, it, expect } from 'vitest';
import { bytesToMB, formatMemoryUsage } from './formatters.js';
import { bytesToMB, formatBytes } from './formatters.js';
describe('bytesToMB', () => {
it('converts bytes to megabytes', () => {
@@ -16,16 +16,16 @@ describe('bytesToMB', () => {
});
});
describe('formatMemoryUsage', () => {
describe('formatBytes', () => {
it('formats values below one megabyte in KB', () => {
expect(formatMemoryUsage(512 * 1024)).toBe('512.0 KB');
expect(formatBytes(512 * 1024)).toBe('512.0 KB');
});
it('formats values below one gigabyte in MB', () => {
expect(formatMemoryUsage(5 * 1024 * 1024)).toBe('5.0 MB');
expect(formatBytes(5 * 1024 * 1024)).toBe('5.0 MB');
});
it('formats values of one gigabyte or larger in GB', () => {
expect(formatMemoryUsage(2 * 1024 * 1024 * 1024)).toBe('2.00 GB');
expect(formatBytes(2 * 1024 * 1024 * 1024)).toBe('2.00 GB');
});
});

2
packages/core/src/utils/formatters.ts
View File

@@ -6,7 +6,7 @@
export const bytesToMB = (bytes: number): number => bytes / (1024 * 1024);
export const formatMemoryUsage = (bytes: number): string => {
export const formatBytes = (bytes: number): string => {
const gb = bytes / (1024 * 1024 * 1024);
if (bytes < 1024 * 1024) {
return `${(bytes / 1024).toFixed(1)} KB`;