refactor(ide): replace DetectedIde enum with IDE_DEFINITIONS object (#8698)

This commit is contained in:
Shreya Keshive
2025-09-18 15:23:24 -04:00
committed by GitHub
parent f2a47dec54
commit db5b49b2ca
16 changed files with 129 additions and 229 deletions
@@ -37,7 +37,7 @@ import { UserAccountManager } from '../../utils/userAccountManager.js';
import { safeJsonStringify } from '../../utils/safeJsonStringify.js';
import { FixedDeque } from 'mnemonist';
import { GIT_COMMIT_INFO, CLI_VERSION } from '../../generated/git-commit.js';
import { DetectedIde, detectIdeFromEnv } from '../../ide/detect-ide.js';
import { IDE_DEFINITIONS, detectIdeFromEnv } from '../../ide/detect-ide.js';
export enum EventNames {
START_SESSION = 'start_session',
@@ -113,7 +113,7 @@ function determineSurface(): string {
} else if (process.env['GITHUB_SHA']) {
return 'GitHub';
} else if (process.env['TERM_PROGRAM'] === 'vscode') {
return detectIdeFromEnv() || DetectedIde.VSCode;
return detectIdeFromEnv().name || IDE_DEFINITIONS.vscode.name;
} else {
return 'SURFACE_NOT_SET';
}