From dd01af609e12be26e42b8ee513a711e376291268 Mon Sep 17 00:00:00 2001 From: Gaurav <39389231+gsquared94@users.noreply.github.com> Date: Mon, 13 Oct 2025 16:26:51 -0700 Subject: [PATCH] refactor: set max retry attempts to 3 (#11072) --- packages/core/src/utils/retry.test.ts | 16 ++++++++-------- packages/core/src/utils/retry.ts | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/core/src/utils/retry.test.ts b/packages/core/src/utils/retry.test.ts index abf9957669..60861d1de6 100644 --- a/packages/core/src/utils/retry.test.ts +++ b/packages/core/src/utils/retry.test.ts @@ -96,34 +96,34 @@ describe('retryWithBackoff', () => { expect(mockFn).toHaveBeenCalledTimes(3); }); - it('should default to 5 maxAttempts if no options are provided', async () => { - // This function will fail more than 5 times to ensure all retries are used. + it('should default to 3 maxAttempts if no options are provided', async () => { + // This function will fail more than 3 times to ensure all retries are used. const mockFn = createFailingFunction(10); const promise = retryWithBackoff(mockFn); // Expect it to fail with the error from the 5th attempt. await Promise.all([ - expect(promise).rejects.toThrow('Simulated error attempt 10'), + expect(promise).rejects.toThrow('Simulated error attempt 3'), vi.runAllTimersAsync(), ]); - expect(mockFn).toHaveBeenCalledTimes(10); + expect(mockFn).toHaveBeenCalledTimes(3); }); - it('should default to 10 maxAttempts if options.maxAttempts is undefined', async () => { - // This function will fail more than 5 times to ensure all retries are used. + it('should default to 3 maxAttempts if options.maxAttempts is undefined', async () => { + // This function will fail more than 3 times to ensure all retries are used. const mockFn = createFailingFunction(10); const promise = retryWithBackoff(mockFn, { maxAttempts: undefined }); // Expect it to fail with the error from the 5th attempt. await Promise.all([ - expect(promise).rejects.toThrow('Simulated error attempt 10'), + expect(promise).rejects.toThrow('Simulated error attempt 3'), vi.runAllTimersAsync(), ]); - expect(mockFn).toHaveBeenCalledTimes(10); + expect(mockFn).toHaveBeenCalledTimes(3); }); it('should not retry if shouldRetry returns false', async () => { diff --git a/packages/core/src/utils/retry.ts b/packages/core/src/utils/retry.ts index b1f79684fd..93a2fc5035 100644 --- a/packages/core/src/utils/retry.ts +++ b/packages/core/src/utils/retry.ts @@ -31,7 +31,7 @@ export interface RetryOptions { } const DEFAULT_RETRY_OPTIONS: RetryOptions = { - maxAttempts: 10, + maxAttempts: 3, initialDelayMs: 5000, maxDelayMs: 30000, // 30 seconds shouldRetryOnError: defaultShouldRetry,